This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Remove manifest plugin #1254
Merged
Remove manifest plugin #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkelty
commented
Dec 13, 2018
| @@ -10,7 +10,6 @@ module.exports = (neutrino, opts = {}) => { | |||
| html: process.env.NODE_ENV === 'development' && { | |||
| title: 'React Preview' | |||
| }, | |||
| manifest: process.env.NODE_ENV === 'development', | |||
| externals: opts.externals !== false && {}, | |||
There was a problem hiding this comment.
@edmorley any idea what purpose this was serving, if any?
There was a problem hiding this comment.
I have no idea :-/
@eliperelman / @helfi92 do you?
edmorley
reviewed
Dec 13, 2018
edmorley
reviewed
Dec 14, 2018
timkelty
force-pushed
the
remove-manifest-plugin
branch
from
3a8b5e4
to
6c65f27
Compare
timkelty
force-pushed
the
remove-manifest-plugin
branch
from
6c65f27
to
20207a0
Compare
edmorley
approved these changes
Dec 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: #1253 (comment)