Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manifest plugin #1254

Merged
merged 7 commits into from Dec 19, 2018
Merged

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented Dec 13, 2018

As discussed here: #1253 (comment)

@timkelty timkelty requested review from eliperelman and edmorley Dec 13, 2018
@@ -10,7 +10,6 @@ module.exports = (neutrino, opts = {}) => {
html: process.env.NODE_ENV === 'development' && {
title: 'React Preview'
},
manifest: process.env.NODE_ENV === 'development',
externals: opts.externals !== false && {},
Copy link
Contributor Author

@timkelty timkelty Dec 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edmorley any idea what purpose this was serving, if any?

Copy link
Member

@edmorley edmorley Dec 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea :-/

@eliperelman / @helfi92 do you?

packages/web/index.js Show resolved Hide resolved
packages/web/index.js Show resolved Hide resolved
@edmorley edmorley added this to the v9 milestone Dec 14, 2018
@timkelty timkelty force-pushed the remove-manifest-plugin branch from 3a8b5e4 to 6c65f27 Compare Dec 19, 2018
@timkelty timkelty force-pushed the remove-manifest-plugin branch from 6c65f27 to 20207a0 Compare Dec 19, 2018
packages/web/README.md Outdated Show resolved Hide resolved
@edmorley edmorley merged commit 448c82c into neutrinojs:master Dec 19, 2018
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants