Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node.js 8 #1481

Merged
merged 1 commit into from Nov 3, 2019
Merged

Conversation

@edmorley
Copy link
Member

edmorley commented Nov 3, 2019

Since it's EOL as of 2019-12-31:
https://nodejs.org/en/about/releases/

...and if we can't support it for the full Neutrino 9 lifecycle, it's best we don't support it from the start at all.

The Travis matrix has also been updated to:

  • test against Node.js 13
  • only test against Node.js 12 on master to reduce the time taken for Travis to complete on PRs/other branches (we only get 5 concurrent builds, and previously there were 6 jobs in the matrix)
Since it's EOL as of 2019-12-31::
https://nodejs.org/en/about/releases/

...and if we can't support it for the full Neutrino 9 lifecycle, it's
best we don't support it from the start at all.

The Travis matrix has also been updated to:
* test against Node.js 13
* only test against Node.js 12 on `master` to reduce the time taken for
  Travis to complete on PRs/other branches (we only get 5 concurrent
  builds, and previously there were 6 jobs in the matrix)
@edmorley edmorley added this to the Neutrino 9 milestone Nov 3, 2019
@edmorley edmorley self-assigned this Nov 3, 2019
@edmorley edmorley requested a review from neutrinojs/core-contributors Nov 3, 2019
Copy link
Contributor

timkelty left a comment

👍💯

@edmorley edmorley merged commit 0c0b207 into neutrinojs:master Nov 3, 2019
6 checks passed
6 checks passed
Header rules No header rules processed
Details
Pages changed 31 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 2 redirect rules processed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@edmorley edmorley deleted the edmorley:edmorley-drop-node-8 branch Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.