Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update to utilize ChromeHeadless as browser in preset-karma. #283
What a wonderful world we now live in.
I like this but I am not sure of adoption of latest Chrome. I expect everyone to be on the latest release, but then again there's always someone stuck with older versions. Angular CLI, for instance, is not using chrome headless (but they updated karma-chrome-launcher to make it possible, see angular/angular-cli#6216)
I did some digging to see if we could work out the risk/timeframe for this.
The Chrome 59 blog post above links to another post with a few more details:
In there, it mentions headless isn't supported on Windows until Chrome 60 (ie later than other platforms) - though not sure if many people use Neutrino on Windows. However reading chromium issue 686608 it also sounds like there were a few other non-platform specific bugs that weren't fixed until Chrome 60 - so it sounds like that's the minimum version people should be targeting regardless.
The latest stable version of Chrome is now 61, with Chrome 60 having been released on the stable channel on 2017-08-24. Surprisingly, the stock chromium-browser package for Ubuntu is already on Chrome 61 for even LTS as old as trusty (see here).
The last remaining pieces are presumably what versions of Chrome/Chromium TravisCI/CircleCI have pre-installed.
For TravisCI, they use the official google chrome binaries rather than chromium. These are installed on all images apart from "connie" (ie anything but
...so there may be a number of people relying on the pre-installed version rather than manually specifying
As for what that pre-installed version is, Travis's cookbook uses the APT repo stable channel rather than a pinned version, so it depends on when the
To confirm, some test builds:
ie: For users on
As for CircleCI, I don't have much experience with it, but it appears their "2.0" platform images use the APT stable channel too, and were updated 14 hours ago - so should be fine:
They also have a legacy "1.0" platform, which is still running Chrome 54.0.2840.100, presuming their docs are up to date with what's actually installed in the Docker image (it's 8GB compressed so not inclined to try):
In conclusion: this could definitely be a breaking change for a very small number of people, so will need a major version bump - however unlike back in July when the previous discussion occurred, it's much more viable to go ahead and land this soon :-)