Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Use scoped packages under the @neutrinojs org #424

Merged
merged 5 commits into from
Nov 14, 2017
Merged

Use scoped packages under the @neutrinojs org #424

merged 5 commits into from
Nov 14, 2017

Conversation

eliperelman
Copy link
Member

Fixes #413.

@eliperelman eliperelman requested a review from a team November 14, 2017 01:11
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, though I see quite a few neutrino-{preset,middleware}- references still left? (eg docs and package.json repository links)

Also, what is the plan for informing existing users that they need to migrate? People relying on greenkeeper/renovate might not know there is a new package name unless we do a another release under the old package names that gives console.warn() deprecation warnings or similar.

@eliperelman
Copy link
Member Author

Yeah, I'll think we will issue deprecation messages once we release v8. Fortunately we've been using peerDependencies, so it shouldn't be too big of a deal. With a major release comes breaking changes, and it should be simple enough for most to just switch packages.

Regarding the references, yeah, I haven't done any docs work yet, but package.jsons should be fixed, so that's my mistake. I'll take a look.

@eliperelman eliperelman requested a review from a team November 14, 2017 21:01
@eliperelman
Copy link
Member Author

OK, I think I have all the references updates from docs.

@edmorley
Copy link
Member

neutrino-dev $ rg 'neutrino-(middleware|preset)-' -g '!CHANGELOG.md'
docs\creating-presets.md
100:mkdir neutrino-preset-standard-style && cd neutrino-preset-standard-style

docs\upgrading-neutrino.md
17:copying directives using the `neutrino-middleware-copy` middleware.
25:e.g. `neutrino.use(minify, { minify: {}, plugin: {} })` or `['neutrino-middleware-minify', { minify: {}, plugin: {} }]`.

docs\api\README.md
386:For a concrete example, the [eslint middleware](../middleware/neutrino-middleware-eslint) registers an `eslintrc`
452:run('build', ['neutrino-preset-react'])
485:api.run('start', ['neutrino-preset-react'])
498:api.use('neutrino-preset-react');
523:api.run('build', ['neutrino-preset-node'])
536:api.use('neutrino-preset-node');
569:api.run('test', ['neutrino-preset-node', 'neutrino-preset-mocha'])
585:api.run('test', ['neutrino-preset-node', 'neutrino-preset-mocha'])
598:api.use('neutrino-preset-node');
599:api.use('neutrino-preset-mocha');
629:api.run('inspect', ['neutrino-preset-node'])
642:api.use('neutrino-preset-node');

packages\web\package.json
14:  "repository": "https://github.com/mozilla-neutrino/neutrino-dev/tree/master/packages/neutrino-preset-web",

@eliperelman
Copy link
Member Author

lol nice find!

@eliperelman
Copy link
Member Author

Updated again, but leaving out upgrading-neutrino and creating-presets since those are not really relevant to this PR.

@eliperelman
Copy link
Member Author

Yay!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants