New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scoped packages under the @neutrinojs org #424

Merged
merged 5 commits into from Nov 14, 2017

Conversation

Projects
None yet
2 participants
@eliperelman
Member

eliperelman commented Nov 14, 2017

Fixes #413.

@eliperelman eliperelman requested a review from neutrinojs/core-contributors Nov 14, 2017

@edmorley

edmorley requested changes Nov 14, 2017 edited

Looks good so far, though I see quite a few neutrino-{preset,middleware}- references still left? (eg docs and package.json repository links)

Also, what is the plan for informing existing users that they need to migrate? People relying on greenkeeper/renovate might not know there is a new package name unless we do a another release under the old package names that gives console.warn() deprecation warnings or similar.

@eliperelman

This comment has been minimized.

Member

eliperelman commented Nov 14, 2017

Yeah, I'll think we will issue deprecation messages once we release v8. Fortunately we've been using peerDependencies, so it shouldn't be too big of a deal. With a major release comes breaking changes, and it should be simple enough for most to just switch packages.

Regarding the references, yeah, I haven't done any docs work yet, but package.jsons should be fixed, so that's my mistake. I'll take a look.

@eliperelman eliperelman requested a review from neutrinojs/core-contributors Nov 14, 2017

@eliperelman

This comment has been minimized.

Member

eliperelman commented Nov 14, 2017

OK, I think I have all the references updates from docs.

@edmorley

This comment has been minimized.

Member

edmorley commented Nov 14, 2017

neutrino-dev $ rg 'neutrino-(middleware|preset)-' -g '!CHANGELOG.md'
docs\creating-presets.md
100:mkdir neutrino-preset-standard-style && cd neutrino-preset-standard-style

docs\upgrading-neutrino.md
17:copying directives using the `neutrino-middleware-copy` middleware.
25:e.g. `neutrino.use(minify, { minify: {}, plugin: {} })` or `['neutrino-middleware-minify', { minify: {}, plugin: {} }]`.

docs\api\README.md
386:For a concrete example, the [eslint middleware](../middleware/neutrino-middleware-eslint) registers an `eslintrc`
452:run('build', ['neutrino-preset-react'])
485:api.run('start', ['neutrino-preset-react'])
498:api.use('neutrino-preset-react');
523:api.run('build', ['neutrino-preset-node'])
536:api.use('neutrino-preset-node');
569:api.run('test', ['neutrino-preset-node', 'neutrino-preset-mocha'])
585:api.run('test', ['neutrino-preset-node', 'neutrino-preset-mocha'])
598:api.use('neutrino-preset-node');
599:api.use('neutrino-preset-mocha');
629:api.run('inspect', ['neutrino-preset-node'])
642:api.use('neutrino-preset-node');

packages\web\package.json
14:  "repository": "https://github.com/mozilla-neutrino/neutrino-dev/tree/master/packages/neutrino-preset-web",
@eliperelman

This comment has been minimized.

Member

eliperelman commented Nov 14, 2017

lol nice find!

@eliperelman

This comment has been minimized.

Member

eliperelman commented Nov 14, 2017

Updated again, but leaving out upgrading-neutrino and creating-presets since those are not really relevant to this PR.

@eliperelman

This comment has been minimized.

Member

eliperelman commented Nov 14, 2017

Yay!

@eliperelman eliperelman merged commit e875c5c into neutrinojs:master Nov 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment