-
Notifications
You must be signed in to change notification settings - Fork 214
Use scoped packages under the @neutrinojs org #424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, though I see quite a few neutrino-{preset,middleware}-
references still left? (eg docs and package.json repository links)
Also, what is the plan for informing existing users that they need to migrate? People relying on greenkeeper/renovate might not know there is a new package name unless we do a another release under the old package names that gives console.warn() deprecation warnings or similar.
Yeah, I'll think we will issue deprecation messages once we release v8. Fortunately we've been using peerDependencies, so it shouldn't be too big of a deal. With a major release comes breaking changes, and it should be simple enough for most to just switch packages. Regarding the references, yeah, I haven't done any docs work yet, but package.jsons should be fixed, so that's my mistake. I'll take a look. |
OK, I think I have all the references updates from docs. |
|
lol nice find! |
Updated again, but leaving out upgrading-neutrino and creating-presets since those are not really relevant to this PR. |
Yay! |
Fixes #413.