This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Set name defaults for file/url-loader #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
eliperelman
suggested changes
Nov 15, 2017
packages/image-loader/index.js
Outdated
| .rule('svg') | ||
| .test(/\.svg(\?v=\d+\.\d+\.\d+)?$/) | ||
| .use('url') | ||
| .loader(urlLoader) | ||
| .options(merge({ limit }, options.svg || {})); | ||
| .options(merge({ limit, name }, options.svg)); |
packages/image-loader/index.js
Outdated
| .rule('img') | ||
| .test(/\.(png|jpg|jpeg|gif)(\?v=\d+\.\d+\.\d+)?$/) | ||
| .use('url') | ||
| .loader(urlLoader) | ||
| .options(merge({ limit }, options.img || {})); | ||
| .options(merge({ limit, name }, options.img)); |
packages/image-loader/index.js
Outdated
| .rule('ico') | ||
| .test(/\.ico(\?v=\d+\.\d+\.\d+)?$/) | ||
| .use('url') | ||
| .loader(urlLoader) | ||
| .options(merge({ limit }, options.ico || {})); | ||
| .options(merge({ limit, name }, options.ico)); |
|
My bad, changes made. |
|
I'd have to look in more detail, but some of the changes in the other PR seem borderline breaking, depending on the weird and wonderful things other people are doing :-) |
|
@edmorley @eliperelman I did a quick review of the borderline-breaking issues here: #434 (comment) |
|
Agreed, this would probably be breaking, we can ship this for v8, and explore demand for v7. |
eliperelman
approved these changes
Nov 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides predictable paths for when using dev-server.
This makes for easier use in a server-side context, and makes things more consistent with how js is named and rev'd.