Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the fast-async babel plugin #790

merged 1 commit into from Apr 16, 2018

Stop using the fast-async babel plugin #790

merged 1 commit into from Apr 16, 2018


Copy link

@edmorley edmorley commented Apr 14, 2018


Fixes #741.

@edmorley edmorley self-assigned this Apr 14, 2018
* The default Neutrino-supported browsers (last two versions of Chrome,
  Firefox, Edge, Opera, Safari & iOS) all support async natively:
* The same applies to Node 8+ (and Neutrino 9 is dropping support
  for Node 6):
* Neutrino 9 final will be released with Babel 7, which will likely
  include built-in support for the fast-async plugin anyway:
* It's another dependency to cause possible regressions, eg:

Fixes #741.
@edmorley edmorley requested a review from eliperelman Apr 14, 2018
Copy link

@eliperelman eliperelman left a comment

Looks good to me!

edmorley added a commit that referenced this issue Apr 16, 2018
The `fast-async` version was pinned in 2edc81a to work around:

That issue was fixed in fast-async v6.3.4, so it's safe to revert
back to a tilde range again.

This only needs applying to the v8 branch, since the version was not
pinned on master (and #790 is about to remove fast-async there).
@edmorley edmorley merged commit ee7b3d9 into neutrinojs:master Apr 16, 2018
2 checks passed
@edmorley edmorley deleted the rm-fast-async branch Apr 16, 2018
@edmorley edmorley added this to the v9 milestone Apr 16, 2018
edmorley added a commit that referenced this issue Sep 14, 2018
Support for the preset option `polyfills.babel` was removed in #315
(Neutrino 7), leaving just `polyfills.async` which was removed in #790.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

2 participants