Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the fast-async babel plugin #790

Merged
merged 1 commit into from Apr 16, 2018

Conversation

@edmorley
Copy link
Member

edmorley commented Apr 14, 2018

Since:

Fixes #741.

@edmorley edmorley self-assigned this Apr 14, 2018
@edmorley edmorley force-pushed the edmorley:rm-fast-async branch from e2ea383 to ea02eaa Apr 14, 2018
edmorley added a commit to edmorley/neutrino that referenced this pull request Apr 14, 2018
The `fast-async` version was pinned in 2edc81a to work around:
MatAtBread/fast-async#53

That issue was fixed in fast-async v6.3.4, so it's safe to revert
back to a tilde range again.

This only needs applying to the v8 branch, since the version was not
pinned on master (and neutrinojs#790 is about to remove fast-async there).
Since:
* The default Neutrino-supported browsers (last two versions of Chrome,
  Firefox, Edge, Opera, Safari & iOS) all support async natively:
  https://caniuse.com/#feat=async-functions
* The same applies to Node 8+ (and Neutrino 9 is dropping support
  for Node 6): http://node.green/#ES2017-features-async-functions
* Neutrino 9 final will be released with Babel 7, which will likely
  include built-in support for the fast-async plugin anyway:
  babel/babel#7076
* It's another dependency to cause possible regressions, eg:
  MatAtBread/fast-async#53

Fixes #741.
@edmorley edmorley force-pushed the edmorley:rm-fast-async branch from ea02eaa to c43797e Apr 14, 2018
@edmorley edmorley requested a review from eliperelman Apr 14, 2018
Copy link
Member

eliperelman left a comment

Looks good to me!

edmorley added a commit that referenced this pull request Apr 16, 2018
The `fast-async` version was pinned in 2edc81a to work around:
MatAtBread/fast-async#53

That issue was fixed in fast-async v6.3.4, so it's safe to revert
back to a tilde range again.

This only needs applying to the v8 branch, since the version was not
pinned on master (and #790 is about to remove fast-async there).
@edmorley edmorley merged commit ee7b3d9 into neutrinojs:master Apr 16, 2018
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@edmorley edmorley deleted the edmorley:rm-fast-async branch Apr 16, 2018
edmorley added a commit to edmorley/neutrino that referenced this pull request Sep 13, 2018
Support for the preset option `polyfills.babel` was removed in neutrinojs#315
(Neutrino 7), leaving just `polyfills.async` which was removed in neutrinojs#790.
edmorley added a commit that referenced this pull request Sep 14, 2018
Support for the preset option `polyfills.babel` was removed in #315
(Neutrino 7), leaving just `polyfills.async` which was removed in #790.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.