Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Simplify the font and image rules/loaders #858

Merged
merged 1 commit into from May 8, 2018
Merged

web: Simplify the font and image rules/loaders #858

merged 1 commit into from May 8, 2018

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented May 8, 2018

  • Switches fonts from url-loader to file-loader (preventing inlining).
  • Consolidates the eot, ttf, and woff rules into a single font rule.
  • Consolidates the ico, img and svg rules into a single image rule.

Fixes #856.

* Switches fonts from `url-loader` to `file-loader` (preventing inlining).
* Consolidates the `eot`, `ttf`, `and `woff` rules into a single `font` rule.
* Consolidates the `ico`, `img` and `svg` rules into a single `image` rule.

Fixes #856.
@edmorley edmorley added this to the v9 milestone May 8, 2018
@edmorley edmorley self-assigned this May 8, 2018
@edmorley edmorley requested a review from eliperelman May 8, 2018
Copy link
Member

@eliperelman eliperelman left a comment

🎉

@edmorley edmorley merged commit c8b5500 into neutrinojs:master May 8, 2018
1 check passed
@edmorley edmorley deleted the simplify-font-image-loaders branch May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants