Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove stringified config output by --inspect #928
Merged
Conversation
This take advantage of the new webpack-chain `toString()` added in neutrinojs/webpack-chain#53. The output from `neutrino --inspect` now lists the correct plugin declarations and arguments, annotates plugins/loaders with hints about how to reference them in a custom Neutrino config, and supports using `__expression` to override the stringified output when needed. The usage of `deep-sort-object` has been removed since it breaks the new `toString()` comment annotations, and really if sorted output is considered important, it should be handled by webpack-chain itself. Fixes #328. Refs #96.
This comment has been minimized.
This comment has been minimized.
|
Note: I don't think we should port back to v8 since that means adding back deep-object-sort, since non-sorted objects is a breaking change. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
Oops haha. |
|
|
edmorley
added a commit
to edmorley/neutrino
that referenced
this pull request
Jun 6, 2018
This backports neutrinojs#928 to `release/v8` under a new argument name, to prevent it from being a breaking change. This will allow Neutrino 8 users to benefit from the stringifed config improvements sooner, as well as providing a way to compare v8 and v9 configurations. I've not backported the eslint `formatter.__expression` change, since it would require a fair amount of refactoring, increasing risk for little benefit. Fixes neutrinojs#328 for `release/v8`.
edmorley
added a commit
that referenced
this pull request
Jun 7, 2018
This backports #928 to `release/v8` under a new argument name, to prevent it from being a breaking change. This will allow Neutrino 8 users to benefit from the stringifed config improvements sooner, as well as providing a way to compare v8 and v9 configurations. I've not backported the eslint `formatter.__expression` change, since it would require a fair amount of refactoring, increasing risk for little benefit. Fixes #328 for `release/v8`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
edmorley commentedJun 5, 2018
•
edited
This takes advantage of the new webpack-chain
toString()added in neutrinojs/webpack-chain#53.The output from
neutrino --inspectnow lists the correct plugin declarations and arguments, annotates plugins/loaders with hints about how to reference them in a custom Neutrino config, and supports using__expressionto override the stringified output when needed.The usage of
deep-sort-objecthas been removed since it breaks the newtoString()comment annotations, and really if sorted output is considered important, it should be handled by webpack-chain itself.Example output for Treeherder's WIP Neutrino 9 config:
https://emorley.pastebin.mozilla.org/9086982
After this merges, I was thinking we could backport this to Neutrino 8 under a separate flag (eg
--inspect-v9) which would make it easier for people to diff Neutrino 8 and 9 configs.Fixes #328.
Refs #96.