Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint: Throw if preset used after compile rule already defined #939

Merged
merged 1 commit into from Jun 7, 2018

Conversation

@edmorley
Copy link
Member

edmorley commented Jun 7, 2018

Presets such as @neutrinojs/web and @neutrinojs/react check to see if a lint rule is defined, and if so, adapt its settings to suit the particular environment/framework. This means that the lint presets must be defined prior to the compile presets or the final eslint configuration will not be correct.

Previously if the ordering was incorrect there would be no error message, causing confusion when eslint wasn't behaving as expected.

Fixes #800.
Refs #763.

Presets such as `@neutrinojs/web` and `@neutrinojs/react` check to
see if a `lint` rule is defined, and if so, adapt its settings to
suit the particular environment/framework. This means that the lint
presets must be defined prior to the compile presets or the final
eslint configuration will not be correct.

However previously this broken ordering would not result in an error
message, causing confusion when eslint wasn't behaving as expected.

Fixes #800.
Refs #763.
@edmorley edmorley added this to the v9 milestone Jun 7, 2018
@edmorley edmorley self-assigned this Jun 7, 2018
@edmorley edmorley requested a review from eliperelman Jun 7, 2018
@edmorley edmorley merged commit 0c615fc into neutrinojs:master Jun 7, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@edmorley edmorley deleted the edmorley:ensure-lint-presets-first branch Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.