use startup command from /usr/share/xsession if DISPLAY_SESSION is set #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarl10
force-pushed
the
startwm-xsession-desktop-files
branch
3 times, most recently
from
be83119
to
46b5a40
Compare
akarl10
changed the title
|
The intention of this (if I'm reading it right) is to give a system manager the chance to force user of a particular desktop. Is that right? |
|
kind of right. if you look for example what gnome defines: you see that the launch command also contains parameters and in that case environment variables. |
matt335672
reviewed
Feb 2, 2023
sesman/startwm.sh
Outdated
| STARTUP=${STARTUP#Exec=*} | ||
| XDG_CURRENT_DESKTOP=$(grep ^DesktopNames= "/usr/share/xsessions/$1.desktop") | ||
| XDG_CURRENT_DESKTOP=${XDG_CURRENT_DESKTOP#DesktopNames=*} | ||
| echo "env XDG_CURRENT_DESKTOP=$XDG_CURRENT_DESKTOP $STARTUP" |
There was a problem hiding this comment.
Suggest echo "env XDG_CURRENT_DESKTOP=\"$XDG_CURRENT_DESKTOP \" $STARTUP", to add "" to the XDG_CURRENT_DESKTOP
|
LGTM. Do you want to squash it into a single commit? Then I'll merge it. |
akarl10
force-pushed
the
startwm-xsession-desktop-files
branch
from
cf108ab
to
bbf3261
Compare
gnome shell has a way to start different desktop profiles, but all use the same gnome-session binary. currently implemented only for debian based distributions
akarl10
force-pushed
the
startwm-xsession-desktop-files
branch
from
bbf3261
to
093baad
Compare
Hiero32
added a commit
to Hiero32/xrdp
that referenced
this pull request
Feb 18, 2023
matt335672
added a commit
that referenced
this pull request
Feb 22, 2023
improve "#2522 use startup command from /usr/share/xsession ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gnome shell has a way to start different desktop profiles, but all use the same gnome-session binary.
also XDG somehow expects that the DESKTOP_SESSION environment variable is set. This value is derived from the .desktop file name in /usr/share/xsessions
There is also a XDG_CURRENT_DESKTOP that comes from that file
on debian/ubuntu setting STARTUP should work, not sure about other distros.