New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-term fix for jade@1.0.0 breaking changes #151

Merged
merged 1 commit into from Dec 23, 2013

Conversation

Projects
None yet
6 participants
@scottnonnenberg
Contributor

scottnonnenberg commented Dec 23, 2013

jade 1.0.0 breaks groc:

Warning: Jade:1
  > 1| !!! 5
    2| html(lang="en")
    3|   head
    4|     title= pageTitle
`!!!` is deprecated, you must now use `doctype`

Unfortunately, because the dependency is specified as "jade": ">= 0.17.0" in the package.json, any new or updated installations are broken right now. This small change will fix them until groc is compatible with jade@1.0.0.

kmdavis pushed a commit that referenced this pull request Dec 23, 2013

Kevan Davis
Merge pull request #151 from scottnonnenberg/changes
Short-term fix for jade@1.0.0 breaking changes

@kmdavis kmdavis merged commit 93e9d77 into nevir:master Dec 23, 2013

@hszcg

This comment has been minimized.

hszcg commented Jan 15, 2014

Hi, I am wondering that when could you push these changes into npm, current npm package it is broken with jade 1.x.

Thanks a lot.

@jewelsjacobs

This comment has been minimized.

jewelsjacobs commented Feb 16, 2014

👍

@krztnkho krztnkho referenced this pull request Feb 17, 2014

Closed

Update package.json #9

@jdcataldo

This comment has been minimized.

Contributor

jdcataldo commented Feb 17, 2014

@nevir @kmdavis Any chance of getting this published to npm?

@variousauthors

This comment has been minimized.

variousauthors commented Feb 24, 2014

How does this fix work? I changed the jade version in the package.json file but am still getting the warning. Is there some equivalent to bundle update I need to do?

@kmdavis

This comment has been minimized.

Collaborator

kmdavis commented Feb 24, 2014

You should only have to do an npm install

@variousauthors

This comment has been minimized.

variousauthors commented Feb 26, 2014

Ah ha! Everything is perfect now, love you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment