Skip to content

Bump puppeteer from 24.43.1 to 25.0.2 in /providers in the puppeteer group #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nev21 merged 9 commits into from
May 30, 2026
Merged

Bump puppeteer from 24.43.1 to 25.0.2 in /providers in the puppeteer group #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b7986f9
Bump puppeteer in /providers in the puppeteer group
dependabot[bot] May 15, 2026
7205fb6
Merge b7986f95ada5444726c0e521cd4d1011cf8b1cd8 into 3e185a313d5634fb6…
dependabot[bot] May 15, 2026
ec7cfcf
chore: syncing versions and shrinkwrap
nevware21-bot May 15, 2026
5d81653
Resolve Puppeteer executable path synchronously
nev21 May 30, 2026
7c98f2b
Resolve Puppeteer executable path synchronously
nev21 May 30, 2026
af027f0
Update Karma worker config for Puppeteer path resolution
nev21 May 30, 2026
c3a5391
Update Puppeteer executable path resolution method
nev21 May 30, 2026
5af1bea
Merge c3a5391c89f16d7a969f7eb2ce1f47e9396aec1a into 3e185a313d5634fb6…
dependabot[bot] May 30, 2026
c728ce4
chore: syncing versions and shrinkwrap
nevware21-bot May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,033 changes: 407 additions & 626 deletions common/config/rush/npm-shrinkwrap.json
View file
Open in desktop

Large diffs are not rendered by default.

26 changes: 24 additions & 2 deletions dbg/karma.browser.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,28 @@
process.env.CHROME_BIN = require('puppeteer').executablePath();
const childProcess = require('child_process');

function _resolvePuppeteerExecutablePathSync() {
return childProcess.execFileSync(process.execPath, [
"-e",
"require('puppeteer').executablePath().then((path) => process.stdout.write(path || ''))"
], {
encoding: "utf8"
}).trim();
}

module.exports = function (config) {
// Puppeteer v25+ resolves executablePath asynchronously, so resolve it in a subprocess
// to keep this Karma config synchronous.
try {
const chromePath = _resolvePuppeteerExecutablePathSync();
if (chromePath) {
process.env.CHROME_BIN = chromePath;
process.env.CHROMIUM_BIN = chromePath;
}
} catch (error) {
console.warn("Puppeteer executable path could not be resolved. Chrome/Chromium tests may be skipped.");
process.exit(0);
}

config.set({
browsers: [ "ChromeHeadlessNoSandbox" ],
listenAddress: 'localhost',
Expand Down Expand Up @@ -53,4 +75,4 @@ module.exports = function (config) {
},
logLevel: config.LOG_INFO
})
};
};
26 changes: 24 additions & 2 deletions dbg/karma.worker.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,28 @@
process.env.CHROME_BIN = require('puppeteer').executablePath()
const childProcess = require('child_process');

function _resolvePuppeteerExecutablePathSync() {
return childProcess.execFileSync(process.execPath, [
"-e",
"require('puppeteer').executablePath().then((path) => process.stdout.write(path || ''))"
], {
encoding: "utf8"
}).trim();
}

module.exports = function (config) {
// Puppeteer v25+ resolves executablePath asynchronously, so resolve it in a subprocess
// to keep this Karma config synchronous.
try {
const chromePath = _resolvePuppeteerExecutablePathSync();
if (chromePath) {
process.env.CHROME_BIN = chromePath;
process.env.CHROMIUM_BIN = chromePath;
}
} catch (error) {
console.warn("Puppeteer executable path could not be resolved. Chrome/Chromium tests may be skipped.");
process.exit(0);
}

const typescript = require("@rollup/plugin-typescript");
const plugin = require("@rollup/plugin-node-resolve");
const commonjs = require("@rollup/plugin-commonjs");
Expand Down Expand Up @@ -61,4 +83,4 @@ module.exports = function (config) {
},
logLevel: config.LOG_DEBUG
})
};
};
3 changes: 2 additions & 1 deletion dbg/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
"karma-coverage": "^2.2.0",
"mocha": "^10.0.0",
"nyc": "^18.0.0",
"puppeteer": "24.43.1",
"puppeteer": "25.0.2",
"rollup": "^4.54.0",
"rollup-plugin-minify-es": "^1.1.1",
"rollup-plugin-istanbul": "^5.0.0",
Expand All @@ -123,3 +123,4 @@




26 changes: 24 additions & 2 deletions providers/karma.browser.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,28 @@
process.env.CHROME_BIN = require('puppeteer').executablePath();
const childProcess = require('child_process');

function _resolvePuppeteerExecutablePathSync() {
return childProcess.execFileSync(process.execPath, [
"-e",
"require('puppeteer').executablePath().then((path) => process.stdout.write(path || ''))"
], {
encoding: "utf8"
}).trim();
}

module.exports = function (config) {
// Puppeteer v25+ resolves executablePath asynchronously, so resolve it in a subprocess
// to keep this Karma config synchronous.
try {
const chromePath = _resolvePuppeteerExecutablePathSync();
if (chromePath) {
process.env.CHROME_BIN = chromePath;
process.env.CHROMIUM_BIN = chromePath;
}
} catch (error) {
console.warn("Puppeteer executable path could not be resolved. Chrome/Chromium tests may be skipped.");
process.exit(0);
}

config.set({
browsers: [ "ChromeHeadlessNoSandbox" ],
listenAddress: 'localhost',
Expand Down Expand Up @@ -53,4 +75,4 @@ module.exports = function (config) {
},
logLevel: config.LOG_INFO
})
};
};
26 changes: 24 additions & 2 deletions providers/karma.worker.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,28 @@
process.env.CHROME_BIN = require('puppeteer').executablePath()
const childProcess = require('child_process');

function _resolvePuppeteerExecutablePathSync() {
return childProcess.execFileSync(process.execPath, [
"-e",
"require('puppeteer').executablePath().then((path) => process.stdout.write(path || ''))"
], {
encoding: "utf8"
}).trim();
}

module.exports = function (config) {
// Puppeteer v25+ resolves executablePath asynchronously, so resolve it in a subprocess
// to keep this Karma config synchronous.
try {
const chromePath = _resolvePuppeteerExecutablePathSync();
if (chromePath) {
process.env.CHROME_BIN = chromePath;
process.env.CHROMIUM_BIN = chromePath;
}
} catch (error) {
console.warn("Puppeteer executable path could not be resolved. Chrome/Chromium tests may be skipped.");
process.exit(0);
}

const typescript = require("@rollup/plugin-typescript");
const plugin = require("@rollup/plugin-node-resolve");
const commonjs = require("@rollup/plugin-commonjs");
Expand Down Expand Up @@ -65,4 +87,4 @@ module.exports = function (config) {
},
logLevel: config.LOG_DEBUG
})
};
};
2 changes: 1 addition & 1 deletion providers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
"karma-coverage": "^2.2.0",
"mocha": "^10.0.0",
"nyc": "^18.0.0",
"puppeteer": "24.43.1",
"puppeteer": "25.0.2",
"rollup": "^4.54.0",
"rollup-plugin-minify-es": "^1.1.1",
"rollup-plugin-istanbul": "^5.0.0",
Expand Down