New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-Blog icons are semi-broken. #1014

Closed
gloomykid opened this Issue Apr 9, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@gloomykid

gloomykid commented Apr 9, 2016

ss 2016-04-09 at 06 01 46

At least this is what it looks like to me. (Chrome-user)

@cdddddd

This comment has been minimized.

Show comment
Hide comment
@cdddddd

cdddddd Apr 19, 2016

image
Same; also a Chrome User.

cdddddd commented Apr 19, 2016

image
Same; also a Chrome User.

yanyi pushed a commit to yanyi/XKit that referenced this issue Apr 27, 2016

Yan Yi Goh
Fix XKit.iframe.hide_button() for Go To Dash
- Amended previously modified Go To Dash
- Modified XKit.iframe.hide_button() to hide Tumblr's .button-label
class
- Fixes new-xkit#1014.
@version365

This comment has been minimized.

Show comment
Hide comment
@version365

version365 May 1, 2016

k4soovn
tbdurxq
vjd6bxq

Same happens on Firefox..

version365 commented May 1, 2016

k4soovn
tbdurxq
vjd6bxq

Same happens on Firefox..

yanyi pushed a commit to yanyi/XKit that referenced this issue May 3, 2016

Yan Yi Goh
Fix XKit.iframe.hide_button() for Go To Dash
- Amended previously modified Go To Dash
- Modified XKit.iframe.hide_button() to hide Tumblr's .button-label
class
- Fixes new-xkit#1014.

yanyi pushed a commit to yanyi/XKit that referenced this issue May 3, 2016

Yan Yi Goh
Fix XKit.iframe.hide_button() for Go To Dash
- Amended previously modified Go To Dash
- Modified XKit.iframe.hide_button() to hide Tumblr's .button-label
class
- Fixes new-xkit#1014.

homu added a commit that referenced this issue May 8, 2016

Auto merge of #1024 - yanyi:master, r=nightpool
Fix Go To Dash 'View' button

Fixed Go To Dash 'View' button previously messing up the iframe. Fixes #1014.

Used the old jQuery style of setting the Dashboard text as empty as I could not find documentation on how to use `XKit.iframe.hide_button();`

@homu homu closed this in #1024 May 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment