Join GitHub today
Fix Go To Dash 'View' button #1024
referenced this pull request
Apr 27, 2016
Hey @nightpool, sorry, I was actually waiting for you to reply on my code changes. Didn't know if I was doing it right since it's my first time making pull request. Been checking this PR daily waiting for a reply actually, haha. But now that 'This branch is out-of-date with the base branch' I am not sure what steps to take.
Currently your PR has 2 junk merge/revert commits and a change to the unrelated "bookmarker" extension, and it needs to be rebased against master so I can merge it. You can read more about rebasing here: https://www.atlassian.com/git/tutorials/rewriting-history/
I'll take a look at both this or #1038 when I get a chance and integrate something that makes sense. Thanks for the contribution!
Looks great. I don't have time to test these two until tomorrow or tonight,
(also, feel free to drop by our gitter chat
On Mon, May 2, 2016 at 10:19 PM Yan Yi Goh firstname.lastname@example.org wrote: