replace Direction with Tank.Direction

.gitignore

@@ -1 +1,2 @@
 /nbproject/
+/NOTES.txt

SpecRunner.html

@@ -19,7 +19,6 @@
 
   <!-- source files -->
   <script type="text/javascript" src="src/Utils.js"></script>
-  <script type="text/javascript" src="src/Direction.js"></script>
   <script type="text/javascript" src="src/Point.js"></script>
   <script type="text/javascript" src="src/Rect.js"></script>
   <script type="text/javascript" src="src/Sprite.js"></script>

spec/CollisionDetectorSpec.js

@@ -6,7 +6,7 @@ describe("CollisionDetector", function () {
     var tank = new Tank(eventManager);
     tank.setRect(new Rect(0, 0, 1, 1));
     tank.setSpeed(1);
-    tank.setDirection(Direction.RIGHT);
+    tank.setDirection(Tank.Direction.RIGHT);
 
     var wall = new Wall();
     wall.setRect(new Rect(1, 0, 1, 1));

spec/TankControllerSpec.js

@@ -1,19 +1,19 @@
 describe("TankController", function () {
   describe("KEY_DOWN", function () {
     it("LEFT", function () {
-      checkKey(Direction.RIGHT, Keyboard.Key.LEFT, Direction.LEFT);
+      checkKey(Tank.Direction.RIGHT, Keyboard.Key.LEFT, Tank.Direction.LEFT);
     });
 
     it("RIGHT", function () {
-      checkKey(Direction.LEFT, Keyboard.Key.RIGHT, Direction.RIGHT);
+      checkKey(Tank.Direction.LEFT, Keyboard.Key.RIGHT, Tank.Direction.RIGHT);
     });
 
     it("UP", function () {
-      checkKey(Direction.LEFT, Keyboard.Key.UP, Direction.UP);
+      checkKey(Tank.Direction.LEFT, Keyboard.Key.UP, Tank.Direction.UP);
     });
 
     it("DOWN", function () {
-      checkKey(Direction.LEFT, Keyboard.Key.DOWN, Direction.DOWN);
+      checkKey(Tank.Direction.LEFT, Keyboard.Key.DOWN, Tank.Direction.DOWN);
     });
 
     function checkKey(initialDirection, pressedKey, expectedDirection) {

spec/TankSpec.js

@@ -16,7 +16,7 @@ describe("Tank", function () {
     });
 
     it("direction should be Right", function () {
-      expect(tank.getDirection()).toEqual(Direction.RIGHT);
+      expect(tank.getDirection()).toEqual(Tank.Direction.RIGHT);
     });
   });
 
@@ -27,7 +27,7 @@ describe("Tank", function () {
   });
 
   it("#setDirection", function () {
-    var DIRECTION = Direction.LEFT;
+    var DIRECTION = Tank.Direction.LEFT;
     tank.setDirection(DIRECTION);
     expect(tank.getDirection()).toEqual(DIRECTION);
   });
@@ -36,19 +36,19 @@ describe("Tank", function () {
     var INIT_X = 0, INIT_Y = 0, SPEED = 1;
 
     it("right", function () {
-      checkDirection(Direction.RIGHT, new Point(INIT_X + SPEED, INIT_Y))
+      checkDirection(Tank.Direction.RIGHT, new Point(INIT_X + SPEED, INIT_Y))
     });
 
     it("left", function () {
-      checkDirection(Direction.LEFT, new Point(INIT_X - SPEED, INIT_Y))
+      checkDirection(Tank.Direction.LEFT, new Point(INIT_X - SPEED, INIT_Y))
     });
 
     it("up", function () {
-      checkDirection(Direction.UP, new Point(INIT_X, INIT_Y - SPEED))
+      checkDirection(Tank.Direction.UP, new Point(INIT_X, INIT_Y - SPEED))
     });
 
     it("down", function () {
-      checkDirection(Direction.DOWN, new Point(INIT_X, INIT_Y + SPEED))
+      checkDirection(Tank.Direction.DOWN, new Point(INIT_X, INIT_Y + SPEED))
     });
 
     function checkDirection(direction, finalPosition) {

src/Tank.js

@@ -3,13 +3,20 @@ function Tank(eventManager) {
 
   this._eventManager = eventManager;
   this._speed = 0;
-  this._direction = Direction.RIGHT;
+  this._direction = Tank.Direction.RIGHT;
 }
 
 Tank.subclass(Sprite);
 
 Tank.SPEED = 4;
 
+Tank.Direction = {
+  RIGHT: 'RIGHT',
+  LEFT: 'LEFT',
+  UP: 'UP',
+  DOWN: 'DOWN',
+};
+
 Tank.prototype.getSpeed = function () {
   return this._speed;
 };
@@ -35,10 +42,10 @@ Tank.prototype.move = function () {
 Tank.prototype._getNewX = function () {
   var result = this._x;
 
-  if (this._direction == Direction.RIGHT) {
+  if (this._direction == Tank.Direction.RIGHT) {
     result += this._speed;
   }
-  else if (this._direction == Direction.LEFT) {
+  else if (this._direction == Tank.Direction.LEFT) {
     result -= this._speed;
   }
 
@@ -48,10 +55,10 @@ Tank.prototype._getNewX = function () {
 Tank.prototype._getNewY = function () {
   var result = this._y;
 
-  if (this._direction == Direction.UP) {
+  if (this._direction == Tank.Direction.UP) {
     result -= this._speed;
   }
-  else if (this._direction == Direction.DOWN) {
+  else if (this._direction == Tank.Direction.DOWN) {
     result += this._speed;
   }
 

src/TankController.js

@@ -15,16 +15,16 @@ TankController.prototype._keyDown = function (key) {
   this._tank.setSpeed(Tank.SPEED);
 
   if (key == Keyboard.Key.LEFT) {
-    this._tank.setDirection(Direction.LEFT);
+    this._tank.setDirection(Tank.Direction.LEFT);
   }
   else if (key == Keyboard.Key.RIGHT) {
-    this._tank.setDirection(Direction.RIGHT);
+    this._tank.setDirection(Tank.Direction.RIGHT);
   }
   else if (key == Keyboard.Key.UP) {
-    this._tank.setDirection(Direction.UP);
+    this._tank.setDirection(Tank.Direction.UP);
   }
   else if (key == Keyboard.Key.DOWN) {
-    this._tank.setDirection(Direction.DOWN);
+    this._tank.setDirection(Tank.Direction.DOWN);
   }
 };