From 5079ca58321a19dc71e91bc7c5a8cd63f359ebeb Mon Sep 17 00:00:00 2001 From: "pixeebot[bot]" <23113631+pixeebot@users.noreply.github.com> Date: Tue, 28 Nov 2023 23:12:09 +0000 Subject: [PATCH] Replace Mutable Default Parameters --- atlassian/bamboo.py | 12 ++++++++---- atlassian/service_desk.py | 16 ++++++++++++---- 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/atlassian/bamboo.py b/atlassian/bamboo.py index c597f2898..64176e9a3 100755 --- a/atlassian/bamboo.py +++ b/atlassian/bamboo.py @@ -786,7 +786,7 @@ def get_deployment_users(self, deployment_id, filter_name=None, start=0, limit=2 resource = "permissions/deployment/{}/users".format(deployment_id) return self.get(self.resource_url(resource), params=params) - def revoke_user_from_deployment(self, deployment_id, user, permissions=["READ", "WRITE", "BUILD"]): + def revoke_user_from_deployment(self, deployment_id, user, permissions=None): """ Revokes deployment project permissions from a given user. :param deployment_id: @@ -794,6 +794,7 @@ def revoke_user_from_deployment(self, deployment_id, user, permissions=["READ", :param permissions: :return: """ + permissions = ["READ", "WRITE", "BUILD"] if permissions is None else permissions resource = "permissions/deployment/{}/users/{}".format(deployment_id, user) return self.delete(self.resource_url(resource), data=permissions) @@ -825,7 +826,7 @@ def get_deployment_groups(self, deployment_id, filter_name=None, start=0, limit= resource = "permissions/deployment/{}/groups".format(deployment_id) return self.get(self.resource_url(resource), params=params) - def revoke_group_from_deployment(self, deployment_id, group, permissions=["READ", "WRITE", "BUILD"]): + def revoke_group_from_deployment(self, deployment_id, group, permissions=None): """ Revokes deployment project permissions from a given group. :param deployment_id: @@ -833,6 +834,7 @@ def revoke_group_from_deployment(self, deployment_id, group, permissions=["READ" :param permissions: :return: """ + permissions = ["READ", "WRITE", "BUILD"] if permissions is None else permissions resource = "permissions/deployment/{}/groups/{}".format(deployment_id, group) return self.delete(self.resource_url(resource), data=permissions) @@ -864,7 +866,7 @@ def get_environment_users(self, environment_id, filter_name=None, start=0, limit resource = "permissions/environment/{}/users".format(environment_id) return self.get(self.resource_url(resource), params=params) - def revoke_user_from_environment(self, environment_id, user, permissions=["READ", "WRITE", "BUILD"]): + def revoke_user_from_environment(self, environment_id, user, permissions=None): """ Revokes deployment environment permissions from a given user. :param environment_id: @@ -872,6 +874,7 @@ def revoke_user_from_environment(self, environment_id, user, permissions=["READ" :param permissions: :return: """ + permissions = ["READ", "WRITE", "BUILD"] if permissions is None else permissions resource = "permissions/environment/{}/users/{}".format(environment_id, user) return self.delete(self.resource_url(resource), data=permissions) @@ -903,7 +906,7 @@ def get_environment_groups(self, environment_id, filter_name=None, start=0, limi resource = "permissions/environment/{}/groups".format(environment_id) return self.get(self.resource_url(resource), params=params) - def revoke_group_from_environment(self, environment_id, group, permissions=["READ", "WRITE", "BUILD"]): + def revoke_group_from_environment(self, environment_id, group, permissions=None): """ Revokes deployment environment permissions from a given group. :param environment_id: @@ -911,6 +914,7 @@ def revoke_group_from_environment(self, environment_id, group, permissions=["REA :param permissions: :return: """ + permissions = ["READ", "WRITE", "BUILD"] if permissions is None else permissions resource = "permissions/environment/{}/groups/{}".format(environment_id, group) return self.delete(self.resource_url(resource), data=permissions) diff --git a/atlassian/service_desk.py b/atlassian/service_desk.py index 1302cbabb..a08c8349c 100644 --- a/atlassian/service_desk.py +++ b/atlassian/service_desk.py @@ -377,7 +377,7 @@ def delete_organization(self, organization_id): return self.delete(url, headers=self.experimental_headers) - def add_users_to_organization(self, organization_id, users_list=[], account_list=[]): + def add_users_to_organization(self, organization_id, users_list=None, account_list=None): """ Adds users to an organization users_list is a list of strings @@ -388,13 +388,15 @@ def add_users_to_organization(self, organization_id, users_list=[], account_list :param users_list: list :return: """ + users_list = [] if users_list is None else users_list + account_list = [] if account_list is None else account_list log.warning("Adding users...") url = "rest/servicedeskapi/organization/{}/user".format(organization_id) data = {"usernames": users_list, "accountIds": account_list} return self.post(url, headers=self.experimental_headers, data=data) - def remove_users_from_organization(self, organization_id, users_list=[], account_list=[]): + def remove_users_from_organization(self, organization_id, users_list=None, account_list=None): """ Removes users from an organization users_list is a list of strings @@ -405,6 +407,8 @@ def remove_users_from_organization(self, organization_id, users_list=[], account :param account_list: list :return: """ + users_list = [] if users_list is None else users_list + account_list = [] if account_list is None else account_list log.warning("Removing users...") url = "rest/servicedeskapi/organization/{}/user".format(organization_id) data = {"usernames": users_list, "accountIds": account_list} @@ -631,7 +635,7 @@ def get_customers(self, service_desk_id, query=None, start=0, limit=50): return self.get(url, headers=self.experimental_headers, params=params) - def add_customers(self, service_desk_id, list_of_usernames=[], list_of_accountids=[]): + def add_customers(self, service_desk_id, list_of_usernames=None, list_of_accountids=None): """ Adds one or more existing customers to the given service desk. If you need to create a customer, see Create customer method. @@ -644,13 +648,15 @@ def add_customers(self, service_desk_id, list_of_usernames=[], list_of_accountid :param list_of_accountids: list :return: the customers added to the service desk """ + list_of_usernames = [] if list_of_usernames is None else list_of_usernames + list_of_accountids = [] if list_of_accountids is None else list_of_accountids url = "rest/servicedeskapi/servicedesk/{}/customer".format(service_desk_id) data = {"usernames": list_of_usernames, "accountIds": list_of_accountids} log.info("Adding customers...") return self.post(url, headers=self.experimental_headers, data=data) - def remove_customers(self, service_desk_id, list_of_usernames=[], list_of_accountids=[]): + def remove_customers(self, service_desk_id, list_of_usernames=None, list_of_accountids=None): """ Removes one or more customers from a service desk. The service desk must have closed access. If any of the passed customers are @@ -662,6 +668,8 @@ def remove_customers(self, service_desk_id, list_of_usernames=[], list_of_accoun :param list_of_accountids: list :return: the customers added to the service desk """ + list_of_usernames = [] if list_of_usernames is None else list_of_usernames + list_of_accountids = [] if list_of_accountids is None else list_of_accountids url = "rest/servicedeskapi/servicedesk/{}/customer".format(service_desk_id) data = {"usernames": list_of_usernames, "accountIds": list_of_accountids}