Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with some links because http:// gets changed to http:/ #1

Open
mccartney opened this issue Jul 22, 2014 · 1 comment

Comments

@mccartney
Copy link

commented Jul 22, 2014

Steps to reproduce

  • in the HTML file use a with http://, e.g.:

    <link href="http://softwarerecs.stackexchange.com/feeds/question/9983">
    

or
[https://github.com/mccartney/web-combiner/blob/master/bug-reports/1/small.html]

  • run inliner, e.g.
    inliner small.html a.html

Observed

  • error message:

      fs.js:432
       return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                      ^
    Error: ENOENT, no such file or directory    'http:/softwarerecs.stackexchange.com/feeds/question/9983'
      at Object.fs.openSync (fs.js:432:18)
      at Object.fs.readFileSync (fs.js:289:15)
      at getFile (/usr/lib/node_modules/web-combiner/inliner.js:43:19)
      at Object.<anonymous> (/usr/lib/node_modules/web-combiner/inliner.js:84:20)
      at Function.b.extend.each (/usr/lib/node_modules/web-combiner/jquery-1.9.1.min.js:3:5257)
      at b.fn.b.each (/usr/lib/node_modules/web-combiner/jquery-1.9.1.min.js:3:2013)
      at jsdom.env.done (/usr/lib/node_modules/web-combiner/inliner.js:77:17)
      at /usr/lib/node_modules/web-combiner/node_modules/jsdom/lib/jsdom.js:207:39
      at process._tickCallback (node.js:419:13)
    
@newghost

This comment has been minimized.

Copy link
Owner

commented Jul 23, 2014

@mccartney

Thank you for reporting this.
You can install the latest from NPM and have a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.