Consolidate configs from minitest-helper to gem #17

Merged
merged 3 commits into from Oct 24, 2012

Conversation

Projects
None yet
3 participants
Owner

bousquet commented Oct 24, 2012

No description provided.

lib/generators/thincloud/test/templates/factory_girl.rb
@@ -1,3 +1,4 @@
class MiniTest::Spec
+ FactoryGirl.find_definitions
@phlipper

phlipper Oct 24, 2012

Collaborator

Move this outside of the class

thincloud-test.gemspec
+ s.add_dependency "guard-minitest", "~> 0.5.0"
+ s.add_dependency "minitest-rails-shoulda", "~> 0.3.0"
+ s.add_dependency "rb-fsevent", "~> 0.9.1"
+ s.add_dependency "simplecov", "~> 0.6.4"
@phlipper

phlipper Oct 24, 2012

Collaborator

bump me to 0.7.x

thincloud-test.gemspec
+ s.add_dependency "minitest-rails-shoulda", "~> 0.3.0"
+ s.add_dependency "rb-fsevent", "~> 0.9.1"
+ s.add_dependency "simplecov", "~> 0.6.4"
+ s.add_dependency "mocha", "~> 0.12.5" # Must be after minitest
@phlipper

phlipper Oct 24, 2012

Collaborator

bump to 0.12.7

-# use factories instead of fixtures
-require "factory_girl"
-FactoryGirl.find_definitions
+require "thincloud-test"
@elskwid

elskwid Oct 24, 2012

Contributor

We're forcing anyone that uses thincloud-test to use our setup here?

@phlipper

phlipper Oct 24, 2012

Collaborator

It is opinionated software... What is an alternative?

@elskwid

elskwid Oct 24, 2012

Contributor

More specifically, does the helper template give more flexibility than having these requirements buried in the gem?

@bousquet

bousquet Oct 24, 2012

Owner

I see thincloud-test as our configuration preferences for a test harness.

@bousquet

bousquet Oct 24, 2012

Owner

You could not require "thincloud-test" in the helper and manually load the components you want.

@elskwid

elskwid Oct 24, 2012

Contributor

I'm not suggesting we cover every possibility. Maybe I should have said what I like about this …. we don't have to worry about updating the helper when we change thincloud-test.

@@ -0,0 +1,8 @@
+class MiniTest::Rails::ActiveSupport::TestCase
+
+ # Register any classes that respond to validate to a specific test class
@elskwid

elskwid Oct 24, 2012

Contributor

Hooray! 🌈

Collaborator

phlipper commented Oct 24, 2012

Merging with @elskwid's blessing 🙏 🌟

phlipper added a commit that referenced this pull request Oct 24, 2012

Merge pull request #17 from bousquet/consolidate-configs
Consolidate configs from minitest-helper to gem

@phlipper phlipper merged commit ccd68e0 into newleaders:master Oct 24, 2012

Contributor

elskwid commented Oct 24, 2012

🌟 okay 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment