feature: instrument go-redis v9 #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sorry for nudging, can you take a look at this again, perhaps I still missed something that prevents this PR from being merged @iamemilio ? |
|
Sorry, we are working on grinding through our PR backlog. We will get to this soon! |
iamemilio
reviewed
Mar 13, 2023
iamemilio
reviewed
Mar 13, 2023
|
Hi, thanks for contributing and sorry for the delay reviewing this. We are planning more time in our schedule to get on top of Pull Requests. We had some questions and nits, but overall this looked good and did what we expected it to! |
Co-authored-by: Emilio Garcia <iamemilio@users.noreply.github.com>
iamemilio
approved these changes
Mar 15, 2023
|
Thanks @gunturaf! These changes will be in the next release of the go agent! |
|
We accidentally merged this into master instead of develop. Attempting to re-open |
Merged
|
Please see #658 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Details
The go-redis package was just moved into
redisGithub organization so the package was renamed fromgithub.com/go-redis/redistogithub.com/redis/go-redis. They also just released new major version (v9) with several breaking changes, notably to the hook system.To ensure smooth upgrade from go-redis v8 to v9, a new integration code is needed.