Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare data directory in windows during msi install #1550

Merged
merged 4 commits into from Feb 15, 2023

Conversation

cristianciutea
Copy link
Contributor

This PR will create New Relic app data directory in c:\ProgramData with the specified permissions

@cristianciutea cristianciutea force-pushed the cciutea/windows_msi_directory_permissions2 branch from 6a89aa4 to 1ba1823 Compare February 14, 2023 09:08
@cristianciutea cristianciutea changed the title change permissions for newrelic app data directory Prepare data directory in windows during msi install Feb 14, 2023
@cristianciutea cristianciutea force-pushed the cciutea/windows_msi_directory_permissions2 branch from 9cce63b to d55bc7e Compare February 14, 2023 09:32
@cristianciutea cristianciutea marked this pull request as ready for review February 14, 2023 09:42
@cristianciutea cristianciutea requested a review from a team as a code owner February 14, 2023 09:42
Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cristianciutea cristianciutea merged commit 37fc10d into master Feb 15, 2023
@cristianciutea cristianciutea deleted the cciutea/windows_msi_directory_permissions2 branch February 15, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants