chore(deps): bump go to v1.16 #699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello, thank you for the PR. That sounds right to me also. It was probably a cary-over from another project, but I see your point. I'll upgrade my local system and run the tests. |
|
It doesn't look like brew has 1.16 yet so I didn't test locally. I think we want to hold this open for a week or so for reasons I can't share yet, but we're on board with this change. |
|
revisit this PR today |
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
relates to the new homebrew version bump |
ctrombley
approved these changes
Jul 13, 2021
NR1 Developer Toolkit Community
automation
moved this from Ready for review
to Review completed
Jul 13, 2021
|
Thanks @chenrui333 , we will continue this effort in #972 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 go 1.16 use go-modules build by default, since this is CLI app, there is no reason to do multiple go versions support. Hence, I have dropped the old go versions.