Agent can forward logs while reconnecting to collector, even when logs are disabled at account level

[JcolemanNR]

Description
A customer has reported that the agent appears to be gathering and forwards logs based on default configuration before the account level disable is observed.

Expected Behavior
When log forwarding is disabled at an account level, the agent will not forward ANY logs to New Relic.

Steps to Reproduce
These are hypothetical, but I believe this is how to reproduce:

• Disable log forwarding at the account level in the NR1 UI.
• Start an application that has logging enabled (by default).
• Manually trigger the agent to reconnect to the collector via NR1 Admin UI.
• While the agent is reconnecting, some logs may be sent to NR1

[JcolemanNR]

The .NET Agent team attempted to reproduce, but was unable. Periodic log event harvest/upload is not scheduled until after the account level server side configuration is observed by the agent.

In multiple testing scenarios, no logs were sent.

[JcolemanNR]

After investigating more, this is a real issue. The behavior can be observed intermittently when the .NET Agent is reconnecting to the collector.

The following lines are where the server provided configuration is cleared out during reconnection. The Scheduled harvest tasks are not fully disabled while this takes place:

newrelic-dotnet-agent/src/Agent/NewRelic/Agent/Core/DataTransport/ConnectionHandler.cs

Lines 432 to 440 in 6bd3982

	private void Disable()
	{
	_dataRequestWire = new NoOpCollectorWire();
	if (string.IsNullOrEmpty(_configuration.AgentRunId?.ToString()))
	return;
	EventBus<ServerConfigurationUpdatedEvent>.Publish(new ServerConfigurationUpdatedEvent(ServerConfiguration.GetDefault()));
	}