Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator transfer from to validators directory, Part 2 #690

merged 29 commits into from Nov 30, 2022


Copy link

@lrafeei lrafeei commented Nov 11, 2022

This is part 2 of 5 for the transfer of the validators from to the validators directory.

Copy link

github-actions bot commented Nov 11, 2022

🦙 MegaLinter status: ERROR

Descriptor Linter Files Fixed Errors Elapsed time
PYTHON black 36 0 0 2.53s
PYTHON flake8 36 0 1.37s
PYTHON isort 36 0 0 0.27s
PYTHON pylint 36 64 11.87s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lrafeei lrafeei marked this pull request as ready for review November 15, 2022 00:56
@lrafeei lrafeei requested a review from a team as a code owner November 15, 2022 00:56
Copy link

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple fixups.

tests/testing_support/ Outdated Show resolved Hide resolved
tests/testing_support/ Outdated Show resolved Hide resolved
@hmstepanek hmstepanek merged commit 87b649f into main Nov 30, 2022
42 of 43 checks passed
@hmstepanek hmstepanek deleted the validator-transfer-p2 branch November 30, 2022 01:07
@umaannamalai umaannamalai added this to the v8.5.0 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants