Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tornado master tests & instrument redis 4.3.5 #695

Merged
merged 4 commits into from Nov 28, 2022

Conversation

hmstepanek
Copy link
Contributor

@hmstepanek hmstepanek commented Nov 22, 2022

Overview

Fix tornado master tests & instrument redis 4.3.5

  1. Drop 3.7 testing from tornado master.
    • Tornado master dropped support for 3.7
  2. Instrument new redis 4.3.5 client methods.

@hmstepanek hmstepanek requested a review from a team as a code owner November 22, 2022 21:16
tornadomaster dropped support for 3.7
@github-actions
Copy link

github-actions bot commented Nov 22, 2022

🦙 MegaLinter status: ERROR

Descriptor Linter Files Fixed Errors Elapsed time
PYTHON bandit 1 0 2.72s
PYTHON black 1 0 0 0.47s
PYTHON flake8 1 18 0.29s
PYTHON isort 1 0 0 0.16s
PYTHON pylint 1 0 2.1s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@hmstepanek hmstepanek changed the title Tornado master dropped support for 3.7 Fix tornadomaster & instrument redis 4.3.5 Nov 22, 2022
@hmstepanek hmstepanek changed the title Fix tornadomaster & instrument redis 4.3.5 Fix tornado master tests & instrument redis 4.3.5 Nov 22, 2022
@TimPansino TimPansino merged commit 60a5d68 into main Nov 28, 2022
42 of 43 checks passed
@TimPansino TimPansino deleted the fix-tornado-failing-tests branch November 28, 2022 18:32
@umaannamalai umaannamalai added this to the v8.5.0 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants