Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in celery where workers don't report data #696

Merged
merged 1 commit into from Nov 30, 2022

Conversation

hmstepanek
Copy link
Contributor

Overview

This fixes Missing information from Celery workers when using MAX_TASKS_PER_CHILD issue.

Previously, if celery was run with the --loglevel=INFO flag, an agent instance would be created for the main celery process and after the first worker shutdown, all following worker's agent instances would point to that agent instance instead of creating a new instance. This was root caused to incorrectly creating an agent instance when application activate was not set. Now no agent instance will be created for the main celery process.

@hmstepanek hmstepanek requested a review from a team as a code owner November 23, 2022 01:10
@github-actions
Copy link

github-actions bot commented Nov 23, 2022

🦙 MegaLinter status: SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
PYTHON bandit 1 0 2.71s
PYTHON black 1 0 0 0.41s
PYTHON flake8 1 0 0.31s
PYTHON isort 1 0 0 0.16s
PYTHON pylint 1 0 2.13s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

This fixes Missing information from Celery workers when using MAX_TASKS_PER_CHILD
issue.

Previously, if celery was run with the --loglevel=INFO flag, an agent instance would be
created for the main celery process and after the first worker shutdown, all following
worker's agent instances would point to that agent instance instead of creating a new
instance. This was root caused to incorrectly creating an agent instance when
application activate was not set. Now no agent instance will be created for the main
celery process.
@hmstepanek hmstepanek force-pushed the fix-celery-worker-no-data-issue branch from 848a9f1 to 8563420 Compare November 30, 2022 01:35
@hmstepanek hmstepanek merged commit 864f086 into main Nov 30, 2022
43 checks passed
@hmstepanek hmstepanek deleted the fix-celery-worker-no-data-issue branch November 30, 2022 01:59
@umaannamalai umaannamalai added this to the v8.5.0 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants