Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Confluent Kafka Producer Arguments #699

merged 4 commits into from Nov 24, 2022


Copy link


Fixes a bug where topic provided as a keyword argument can crash confluent kafka producers.

@TimPansino TimPansino requested a review from a team as a code owner November 23, 2022 22:28
Copy link

github-actions bot commented Nov 23, 2022

🦙 MegaLinter status: ERROR

Descriptor Linter Files Fixed Errors Elapsed time
PYTHON bandit 1 0 2.41s
PYTHON black 2 0 0 0.58s
PYTHON flake8 2 18 0.28s
PYTHON isort 2 1 0 0.17s
PYTHON pylint 2 0 2.26s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

hmstepanek previously approved these changes Nov 23, 2022
@hmstepanek hmstepanek dismissed their stale review November 23, 2022 23:14

tests are failing

@hmstepanek hmstepanek self-requested a review November 24, 2022 01:41
Copy link

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hmstepanek hmstepanek merged commit eead7a7 into main Nov 24, 2022
40 of 43 checks passed
@hmstepanek hmstepanek deleted the fix-confluentkafka-producer branch November 24, 2022 01:43
@umaannamalai umaannamalai added this to the v8.5.0 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants