Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce bundle size #49

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Reduce bundle size #49

merged 2 commits into from
Dec 8, 2022

Conversation

ryo-rm
Copy link
Contributor

@ryo-rm ryo-rm commented Dec 8, 2022

Thanks for the great library. We are using it in our products.
One thing I did notice was the large bundle size.

Metro does not currently implement tree shaking.Only lodash.foreach is used, but all code is bundled.
Changing to lodash.foreach will reduce the bundle size.

This change reduces the bundle size by approximately 70 KB.

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@kennyt276 kennyt276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for submitting a PR for this. The changes look good to me and should help with the bundle size. Appreciate the help!

@kennyt276 kennyt276 merged commit bb852b1 into newrelic:develop Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants