Reduce bundle size#49
Merged
Merged
Conversation
|
|
kennyt276
approved these changes
Dec 8, 2022
Contributor
kennyt276
left a comment
kennyt276
left a comment
There was a problem hiding this comment.
Hello, thanks for submitting a PR for this. The changes look good to me and should help with the bundle size. Appreciate the help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great library. We are using it in our products.
One thing I did notice was the large bundle size.
Metro does not currently implement tree shaking.Only
lodash.foreachis used, but all code is bundled.Changing to
lodash.foreachwill reduce the bundle size.This change reduces the bundle size by approximately 70 KB.