Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rspec render_template specs are failing #169

Closed
PratheepV opened this issue Jun 3, 2014 · 6 comments
Closed

Rspec render_template specs are failing #169

PratheepV opened this issue Jun 3, 2014 · 6 comments

Comments

@PratheepV
Copy link

Hi,

Recently I upgraded the newrelic agent version from 3.5.0.83 to 3.8.1.221. When I ran my specs, Failing because of render template checks. I just dig into rpm code, it was working till v3.6.0 , after that I think you guys enhanced the monitoring for view renders.

https://github.com/newrelic/rpm/blob/master/lib/new_relic/agent/instrumentation/action_view_subscriber.rb#L86

I am using "rspec", "1.3.1".

Thanks,
Pratheepv

@PratheepV PratheepV changed the title Rspec render_template returning nil instead of true flase Rspec render_template specs are failing Jun 3, 2014
@jasonrclark
Copy link
Contributor

Hi @PratheepV, thanks for the report! Any chance we could get the exact stack trace and error that you get out of the spec run?

@PratheepV
Copy link
Author

Hi jasonrclark,

my spec file is simple

it "should go to the index page" do
    get 'index' 
    response.should render_template "index.html.erb"
end

Result
'HomeController should go to the index page' FAILED
expected "index.html.erb", got nil

Thanks,
Pratheepv

@jasonrclark
Copy link
Contributor

@PratheepV Thanks for sending that along. I plugged that into an app and wasn't able to duplicate any change in the behavior, but I doubt I'm on the precise versions you're on. Any chance you could gist your Gemfile + Gemfile.lock so I can be sure I'm trying the same versions?

Additionally, the agent shouldn't even be running when you are running your specs. Can you confirm that removing newrelic_rpm from the Gemfile, bundling and re-running specs passes?

@PratheepV
Copy link
Author

Hi,

Ours is a proprietary software, So its not possible to disclose all gems what we are using in it. I will give you the newrelic gem version.

    gem "newrelic_rpm","3.8.1.221"

When I downgrade teh newrelic gem to 3.6.0.83 all my specs are passing. we are using rails 2.3. By any chance you tried the rails 4?

Thanks,
Pratheepv

@jasonrclark
Copy link
Contributor

Hi @PratheepV, I understand your concern.

Is there any chance that you could enter a ticket via https://support.newrelic.com/home where potentially you could share a bit more of the versions you're using of other gems?

Any generally useful results from the ticket will get posted back here as well to help others, but that'll let us keep the intervening discussion private.

Thanks

@PratheepV
Copy link
Author

Hi @jasonrclark ,

I created a case in your support.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants