Make sure cursor.collection exists #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use `nextObject` method of a `cursor` object on a non-existent collection it crashes your application. Found and fixed with @humanchimp
|
@gokmen this is fantastic. I'll have to write a test for this, but if you have any tests I can leverage or examples that would be great too. |
|
We've rewritten the mongo instrumentation since this PR was put up. Going to close it out. |
cmcadams-newrelic
pushed a commit
to cmcadams-newrelic/node-newrelic
that referenced
this pull request
Jan 29, 2024
…/nestjs-config-file/babel/traverse-7.23.2 chore(deps-dev): bump @babel/traverse from 7.22.5 to 7.23.2 in /nestjs-config-file
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 19, 2024
…/protobufjs-6.11.3 Bump protobufjs from 6.11.2 to 6.11.3
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 23, 2024
…/protobufjs-6.11.3 Bump protobufjs from 6.11.2 to 6.11.3
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Jul 26, 2024
…/protobufjs-7.2.4 Bump protobufjs from 7.2.3 to 7.2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use
nextObjectmethod of acursorobject on a non-existent collection it crashes your application. Found and fixed with @humanchimp