Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] Instrument tedious MSSQL driver #277
It includes integration tests for
I opened the PR as WIP in order to get feedback on the implementation and tests before adding the following:
Second, (after a bit of discussion with the team and some other stakeholders), we're trying to move away from including every single DB package possible in the agent. There's lot of complicated reasons for this (some technical, some long-term-support, some "other"), but we're not sure we'd be able to accept your awesome instrumentation into the agent as a first party thing right now.
So -- next steps?
That should make it available to folks who want to use it without all the red-tape of getting it into the agent proper.
I'm going to close this PR for now, but if you've got any questions about
@astormnewrelic I can definitely understand how it could be a maintenance burden to instrument a number of 3rd party packages. If the future direction of the agent is individual module instrumentations, would it be possible to create a separate package for some of the integration test utilities (ex: