I0010 sync since timestamp #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ciQuery != "" && lastUpdate != nil { | ||
| ciQuery, err = subsDateTime(ciQuery, config, lastUpdate) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error evaluating query template: %v", err) |
There was a problem hiding this comment.
Change this error message. No longer using template.
|
|
||
| i.Logger.Warnf( | ||
| "errors while updating entity %s: see below for errors", | ||
| entityOutline.Name, |
There was a problem hiding this comment.
Should include guid here as above messages.
internal/sync/entity_processor.go
Outdated
|
|
||
| vars := map[string]interface{}{ | ||
| "query": query, | ||
| } |
There was a problem hiding this comment.
Remove tabs here
internal/sync/entity_processor.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| return &resp, nil |
There was a problem hiding this comment.
Remove tab here
|
|
||
| "github.com/gofrs/uuid" | ||
| "github.com/newrelic/newrelic-client-go/pkg/nrdb" | ||
| ) |
There was a problem hiding this comment.
Remove tabs
internal/sync/events.go
Outdated
|
|
||
| latestTimestamp, ok := val.(float64) | ||
| if !ok { | ||
| s.log.Warn("timestamp attribute found in result is not an integer") |
There was a problem hiding this comment.
is not a float
internal/sync/sync.go
Outdated
| cycleId, err := uuid.NewV4() | ||
| if err != nil { | ||
| s.syncFailed(uuid.Nil, err) | ||
| } |
There was a problem hiding this comment.
Remove tabs
| // ext entity key - no | ||
| if entityTagExists { | ||
| // entity key - yes, delete tag | ||
| tagsToDelete = append(tagsToDelete, entityTagName) |
There was a problem hiding this comment.
Add comment here that this is (obviously) destructive.
pkg/interop/interop.go
Outdated
| @@ -37,49 +47,57 @@ func NewInteroperability() (*Interop, error) { | |||
| viper.SetConfigName("config") | |||
| viper.AddConfigPath("configs") | |||
| viper.AddConfigPath(".") | |||
| viper.SetDefault("events.enabled", true) | |||
There was a problem hiding this comment.
This doesn't actually work, remove.
| if licenseKey == "" { | ||
| return fmt.Errorf("missing New Relic license key") | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't really think we need a license key unless we are using events but can leave this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue.
Type of change
functionality to not work as expected)
Checklist: