fix: summary panel nrql query issues (Fixes #10) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tangollama
reviewed
Feb 19, 2020
tangollama
reviewed
Feb 19, 2020
| <NerdGraphQuery query={nrql}> | ||
| {({ loading, error, data }) => { | ||
| if (loading) { | ||
| return <Spinner style={{ height: '110px' }} />; |
There was a problem hiding this comment.
What about just fillContainer vs. a custom style?
There was a problem hiding this comment.
We can do that. The difference is fillContainer covers the entire right panel (summary + charts) whereas this height restriction made it so the spinner covered just the summary component (i.e. less overall "flashing" when a new process is selected). I'm good to change it to fillContainer if we want to favor using the built-in props.
tangollama
reviewed
Feb 19, 2020
devfreddy
previously requested changes
Feb 19, 2020
…avor of built-in prop
|
Looks like all the changes are present in the files now. Not sure why the 4th commit didn't come through in the conversation but ¯_(ツ)_/¯ |
|
🎉 This PR is included in version 0.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NrqlQuerycomponent withNerdGraphQuery(also utilizesNerdGraphErrorfor convenient error handling)NrqlQuerycomponent fail to return data whenNrqlQuery.FORMAT_TYPE.RAWis specified. I did a test with the SINCE clause continuously updating vs remaining static to determine this is an issue. It seems something in the service itself is not responding with data, so we may need to look into this more in case it impacts other Nerdpacks. SwitchingNrqlQueryout forNerdGraphQueryaddressed the issue.