discovery/ksm: improvements to discovery strategy #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roobre
changed the title
roobre
added
bug
In order to discover the pod where KSM is located, we make non-namespaced requests to the API server searching for different labels. The helm chart we're currently deploying as a dependency uses: app.kubernetes.io/name=kube-state-metrics This commit moves this label to be the first one being tried, which should reduce the number of requests to the API server to 1/3 when KSM is deployed with its helm chart (which is, to our understanding, the most common scenario).
paologallinaharbur
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.