E2E test improvements #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated and curated from nri-kubernetes 2.4.0 in minikube v1.20.0 on Kubernetes v1.19.11
paologallinaharbur
force-pushed
the
e2e-test-improvements
branch
from
1f5d439
to
d33dab4
Compare
paologallinaharbur
approved these changes
May 26, 2021
paologallinaharbur
changed the title
roobre
commented
May 26, 2021
e2e/schema/service.json
Outdated
| @@ -94,7 +93,6 @@ | |||
| } | |||
| ], | |||
| "required": [ | |||
| "clusterIP", | |||
There was a problem hiding this comment.
I agree with this change, but I don't understand why some services (or versions) are not returning this. Do you know the root cause?
There was a problem hiding this comment.
I am investigating that
There was a problem hiding this comment.
For some reason the service created forces the clusterIP to be none @roobre
There was a problem hiding this comment.
I am currently testing locally to re-add clusterIP
paologallinaharbur
changed the title
paologallinaharbur
force-pushed
the
e2e-test-improvements
branch
from
9bce801
to
2a8cb2b
Compare
|
I removed the e2e support for helm3 in favour of #110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main objective of this PR is: