Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nrFiltered attribute to namespaceSample when filtering by namespace #496

Merged
merged 5 commits into from
Jun 20, 2022
Merged

Add nrFiltered attribute to namespaceSample when filtering by namespace #496

merged 5 commits into from
Jun 20, 2022

Conversation

alvarocabanas
Copy link
Contributor

Signed-off-by: Alvaro Cabanas acabanas@newrelic.com

@alvarocabanas alvarocabanas marked this pull request as ready for review June 16, 2022 14:23
@alvarocabanas alvarocabanas requested a review from a team June 16, 2022 14:26
marcsanmi
marcsanmi approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alvarocabanas alvarocabanas changed the title Avoid filtering hpa and namespace KSM metrics Add nrFiltered label to namespaceSample when filtering by namespace Jun 20, 2022
@alvarocabanas alvarocabanas changed the title Add nrFiltered label to namespaceSample when filtering by namespace Add nrFiltered attribute to namespaceSample when filtering by namespace Jun 20, 2022
@alvarocabanas
Avoid filtering hpa and namespace KSM metrics
0236bfc 
Signed-off-by: Alvaro Cabanas <acabanas@newrelic.com>
@alvarocabanas
Add label filtered to NamespaceSample when other entities filtered
4bade1a
@alvarocabanas
Don't filter hpa
dbd54a5
@alvarocabanas
Add label nrFiltered to namespaces when filter is in place.
d04d07a 
Signed-off-by: Alvaro Cabanas <acabanas@newrelic.com>
@alvarocabanas
Update changelog
6ecc7d8 
Signed-off-by: Alvaro Cabanas <acabanas@newrelic.com>
@alvarocabanas alvarocabanas merged commit cbd5783 into main Jun 20, 2022
@alvarocabanas alvarocabanas deleted the avoid_filtering_namespace_hpa branch June 20, 2022 07:29
@alvarocabanas alvarocabanas mentioned this pull request Jun 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paologallinaharbur paologallinaharbur paologallinaharbur approved these changes

@marcsanmi marcsanmi marcsanmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvarocabanas @marcsanmi @paologallinaharbur