This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
RUBY-669 moved Resque instrumentation to newrelic_rpm
- Loading branch information
Showing
5 changed files
with
6 additions
and
158 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
dde214b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
You have removed the Resque support from the "stable" version of this gem, saying that it is now in the main RPM gem but as of now, it's only on the
dev
branch (that will become version3.4.0
) which is not published yet.Does it mean that there is no Resque instrumentation in RPM if we have the latest version of the two gems ?
Thanks
dde214b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlecour, we're planning to release version 3.4.0 in a couple weeks, which, as you mention, adds resque support to the newrelic_rpm gem.
In the meantime you have a few options.
You can run 3.4.0.beta1 (http://rubygems.org/gems/newrelic_rpm/versions/3.4.0.beta1) which has the resque instrumentation included.
Alternatively, if you don't want to put a beta in production, I'd suggest running newrelic_rpm version 3.3.5 (the current GA) with the previous version of rpm_contrib (2.1.10). The only change made to rpm_contrib between 2.1.10 and 2.1.11 is to remove the resque instrumentation (and update the README).
Hopefully that will work for you. Sorry for the hassle.
dde214b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @samg
That's exactly what I've done ; specify the
rpm_contrib
version to 2.1.10 untilnewrelic_rpm
3.4 is released.Thanks
dde214b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the mean time someone should update the Resque docs on NewRelic. I wasted a lot of time trying to get things working before coming across this comment thread attached to a commit in the git repo. It's not really where I'd expect to have to go for up to date installation info.