Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Plugin init compatible with Rails 4 #33

Merged
merged 1 commit into from Feb 8, 2013

Conversation

Projects
None yet
2 participants
Contributor

jlecour commented Jan 17, 2013

The plugin initialization checks for Rails version 2 or 3, but nothing is done for Rails 4.

I don't know if there is a better way to check for Rails versions, but looking for 3 or 4 is the simplest working change.

Feel free to improve ;)

PS : I've filed a ticket on NewRelic support site about this, but having an issue tracker within the GitHub project would be very useful.

jasonrclark added a commit that referenced this pull request Feb 8, 2013

Merge pull request #33 from jlecour/rails4
Plugin init compatible with Rails 4

@jasonrclark jasonrclark merged commit 7d6f456 into newrelic:master Feb 8, 2013

Member

jasonrclark commented Feb 8, 2013

Thanks for catching that. Looks good to me.

Contributor

jlecour commented Feb 10, 2013

Thanks for applying this.

Any chance to have a gem released in a near future ?

Member

jasonrclark commented Feb 11, 2013

Typically we're only releasing this gem when a larger change is ready (normally an extraction of instrumentation to another gem these days).

FWIW, there should be very little churn on the repo, so pointing via git should remain pretty stable. Let me know if this is a major blocker for you though.

Contributor

jlecour commented Feb 11, 2013

@jasonrclark OK, I understand. I'll point my Gemfile to the branch.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment