Slash required on URL #30

Closed
moneal opened this Issue Mar 22, 2012 · 3 comments

Projects

None yet

3 participants

@moneal
moneal commented Mar 22, 2012

From what I see you can request anything but the root of a site. If you try to test url like http://example.com/test.html you get this error "bees: error: It appears your URL lacks a trailing slash, this will disorient the bees. Please try again with a trailing slash."

Apache bench works fine for testing files.

@weotch
weotch commented Apr 12, 2012

I'd like to see this changed as well

@weotch
weotch commented Apr 12, 2012

I commented it out, like so: #31

@cosmin
Collaborator
cosmin commented Jan 3, 2013

To clarify, ab requires a trailing slash for URLs without a path component, such as http://example.com. The current check does not discriminate and forces a trailing slash on all URLs, which is clearly not ideal. Instead of tuning the regex I would like to actually parse the supplied URL, and if necessary add a trailing slash for bare URLs rather than forcing this particular implementation detail upon the user.

@cosmin cosmin closed this in 216f3ea Jan 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment