Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for minor bug with the -n parameter #37

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants

cjbehm commented Aug 24, 2012

In testing that fix I kept getting a confusing error about NoneType and it turns out that when you pass -n 1 to ab, it doesn't return data in the format that bees expects. To work around that I included a requirement that -n is at least 2.

cjbehm added some commits Aug 24, 2012

@cjbehm cjbehm ENHANCE TRAILING SLASH REGEX
Replace the regular expression that checks for "bare" domains
with one that can detect bare domain URLs but allow regular URLs
that ab can use (e.g. flag http://somedomain.com and allow
http://somedomain.com/somefile.html).
f5de324
@cjbehm cjbehm WORKAROUND ISSUE WITH AB RESULTS
If a user provides -n 1 for the attack, ab does not return the
expected result set and bees crashes with a confusing error. To
avoid this entirely, add a check for the attack command that
requires at least -n 2 (two requests)
6599364
Collaborator

cosmin commented Jan 3, 2013

Going to address the trailing slash issue as part of #30

Collaborator

cosmin commented Jan 10, 2013

The -n argument to bees actually needs to be at least 2 * number of instances, but we don't have access to the number of instances when validating arguments.

Collaborator

cosmin commented Jan 10, 2013

Fixed in 3c98561

@cosmin cosmin closed this Jan 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment