mark-feed-read when filter is applied should only mark visible items read

[tonycpsu]

Newsboat version (copy the output of newsboat -v or the first line of git show):

r2.21-362-g80f1

Steps to reproduce the issue:

1. Apply a filter by pressing F and type in title =~ "(string that's only in a subset of articles)"

2. Press A to mark all read.

Expected: only visible articles are read, similar to if one had used / (open-search) to do the filtering instead of a filter.

Actual: all articles in the feed are read.

My guess is this happens because / creates a temporary "feed" and marks it read, while filters work differently? Anyway, seems like they should work the same, or perhaps a new mark-visible-read command could be added?

[Minoru]

Reproduced on 8880ba4, thanks for the report!

My guess is this happens because / creates a temporary "feed" and marks it read, while filters work differently?

Exactly. Filters are applied at "display" time, by filtering out the items that don't match:

newsboat/src/itemlistformaction.cpp

Lines 916 to 923 in 8880ba4

	for (const auto& item : items) {
	item->set_index(i + 1);
	if ((show_read || item->unread()) &&
	(!apply_filter || matcher.matches(item.get()))) {
	new_visible_items.push_back(ItemPtrPosPair(item, i));
	}
	i++;
	}

seems like they should work the same

Yes, I think the expected behaviour you describe is the correct one.