Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upbind-key not honored in article view #200
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Minoru
May 20, 2018
Member
Hi! Indeed, with 2.11.1, I see the following:
- only
Oworks in articlelist,oandadon't; - only
Ois listed in help dialog for articlelist,oandaaren't.
But in 2.10 (released 8 months ago), it behaved the same!
Also:
- from what I gather with quick search over Git log,
open-in-browser-and-mark-readwas part of articlelist from the very beginning, but was never implemented for articleview; open-all-unread-in-browser-and-mark-readdoesn't make sense for articleview, because there's only one article in it—there is no "all" to speak of.
Are you sure you didn't tweak your keybinds recently? I don't see how the ones you show could've worked in any Newsboat (or Newsbeuter!) version.
|
Hi! Indeed, with 2.11.1, I see the following:
But in 2.10 (released 8 months ago), it behaved the same! Also:
Are you sure you didn't tweak your keybinds recently? I don't see how the ones you show could've worked in any Newsboat (or Newsbeuter!) version. |
Minoru
added
bug
cannot-reproduce
labels
May 20, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pushcx
May 20, 2018
No, I haven't touched them in months. I swear I've seen o -> open-in-browser-and-mark-read work, but maybe I'm imagining things.
Well, if this can't have worked I suppose it's not a bug. Perhaps it could be a feature request? I'd really like it to work. I can understand why a working would be a little odd.
pushcx
commented
May 20, 2018
|
No, I haven't touched them in months. I swear I've seen Well, if this can't have worked I suppose it's not a bug. Perhaps it could be a feature request? I'd really like it to work. I can understand why |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Minoru
May 21, 2018
Member
Both of them would be odd, actually. open-in-browser-and-mark-read is odd for articleview because if you're looking at an article, it's already marked as read—no need to do it again.
Can you explain how making these work will make your life better, or help you in any way?
|
Both of them would be odd, actually. Can you explain how making these work will make your life better, or help you in any way? |
Minoru
added
enhancement
to consider
and removed
bug
cannot-reproduce
labels
May 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pushcx
May 21, 2018
I don't have to think. I can hit o to move on from the article, secure that it's in the browser and marked. Otherwise it's o in articlelist but On in the detail view.
pushcx
commented
May 21, 2018
|
I don't have to think. I can hit |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Minoru
May 22, 2018
Member
I see. Ideally, this should be solvable with out macro key system, but it doesn't let you write a macro for a specific dialog yet, and it makes you press an additional key to invoke the macro.
I still don't wan't to add open-in-browser-and-mark-read to articleview, because it's main purpose—opening and marking—doesn't completely make sense there, and once added, it will be very hard to remove.
So the only remedy I have for you right now is to do something like this:
unbind-key o
bind-key o open-in-browser-and-mark-read articlelist
bind-key o open-in-browser articleview
This will let you press o in articlelist and on in articleview, which is slightly less typing.
|
I see. Ideally, this should be solvable with out macro key system, but it doesn't let you write a macro for a specific dialog yet, and it makes you press an additional key to invoke the macro. I still don't wan't to add So the only remedy I have for you right now is to do something like this:
This will let you press |
pushcx commentedMay 20, 2018
In
newsboat 2.11.1I have some bound keys:These keys work when the feed list and in the list of articles in a particular feed, and I see them when I hit
?for the list of keys. When I'm viewing an individual article, the bindings foroandadon't work and are missing from the list of keys, thoughOis listed asopen-in-browser.These shortcuts used to work in all views and stopped working in the last month or two. I'm sorry, I don't know exactly which version they stopped working in.
Thanks for any help, and for a great newsreader.