Home of The Times' react components.
We require MacOS with Node.js (for specific version please check package.json restrictions), yarn (latest)
You can try without these requirements, but you'd be on your own.
Go to http://components.thetimes.co.uk
-
Run
yarn install -
Components can be seen running in a storybook
- storybook
yarn storybook- go to http://localhost:9001
See utils package on how to update the schema.
The components in this project can be debugged through your browser's developer tools. These steps assume the use of Chrome DevTools.
To debug our web Storybook:
yarn storybook- navigate to http://localhost:9001
- open DevTools
- Click Sources
- In the Network tab under the leftmost pane, expand top => storybook-preview-iframe => webpack:// => . => packages
Any of these source files can be debugged directly.
Follow these steps here
Besides linking the Times Components and Render repos together, you can view changes made to Times Components in Render through the rnw.js files.
- In Times Components, after you have made your changes, run
yarn bundlein the package in which you were working. If you were working in thets-componentspackage you will need to runyarn buildfirst and thenyarn bundle. - Running the command creates an rnw.js file in the root of the folder. Check the file to see if your changes have come through.
- Copy the contents of the rnw.js file and paste it into the related file in Render's
node_modules. For example, if you bundled the rnw.js file in thearticle-skeletonpackage in Times Components, you would paste the contents intonode_modules/@times-components/article-skeleton/rnw.js. - Run render and you should see your changes.
Tests are currently using jest to run so if you want to debug any test follow these steps:
-
(FIND YOUR TEST COMMAND)
jest --config="./packages/provider/__tests__/jest.config.js". Depending on what directory we start the tests from, the--configdirectory may differ. My currenct directory is at the repo root:times-components. -
See your test command from the
package.jsonfor the speciffic package you want to check out.
NOTE: If you don't have jest installed globally, you can use it locally from the
node_modules/.bin/jest
- (START TESTS IN DEBUG MODE) We need to start the same command but through node while in debug mode like so:
node --inspect-brk ./node_modules/.bin/jest --config="./packages/provider/__tests__/jest.config.js" --runInBand
NOTE:
--runInBandis ajestflag that runs all tests serially in the current process. If we don't add this flag, only the node process that startedjestwill be debuggable .
-
(ADD DEBUG STATEMENTS) Normaly we would add breakpoints, but when remote debugging that's not always possible, because the files we need to put the breakpoints on aren't loaded yet by
jest. So in order to make the debugger stop where we want it to, we need to adddebugger;statements instead of breakpoints in the code and re-transpile if necessary. -
(ATTACH TO WEB SOCKET) Once we've started the tests in debug mode, we need to attach to it:
-
(RECOMMENDED) use chrome remote debug for node:
- open
chrome://inspectin chrome address bar Open dedicated DevTools for Nodebutton- If you've started the tests with the aforementioned command it should automatically connect, but if it doesn't go to the
Connectiontab of the pop-up window and add connectionlocalhost:9229or whatever your port is - The debugger should stop on the first line because of the
--inspect-brkflag and once you press the play button (resume execution) it should stop on yourdebugger;statement
NOTE: once it stops you may see all of your code is bundled up in one line. There's an easy fix for that: at the bottom of the debug window near the
Line: 1 Column: 1labels you should see a{}button that will prettify your code and you will still be able to debug properly. - open
-
(Use VSCode) Config should look close to this:
...
"configurations": [
{
"localRoot": "${workspaceFolder}/packages/provider", //change this depending on what test you're debugging
"remoteRoot": "${workspaceFolder}/packages/provider", //change this depending on what test you're debugging
"type": "node",
"request": "attach",
"name": "Attach to Server on 9229",
"address": "127.0.0.1",
"port": 9229
}
]See the CONTRIBUTING.md for an extensive breakdown of the project.
yarn commit will commit files (same as git commit), and will aid the
contributor with adding a suitable commit message inline with
conventional changelog