Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Rolled out eslint config for all test environments #530

Merged
merged 6 commits into from Jan 15, 2018
Merged

refactor: Rolled out eslint config for all test environments #530

merged 6 commits into from Jan 15, 2018

Conversation

colincclark
Copy link
Contributor

@colincclark colincclark commented Jan 15, 2018 •
edited

This is to standardize how we do it, and remove annoying extraneous eslint comments from test files

  • Removed unrequired eslint comments
  • Added eslint config files to all test folders
  • Amended the CLI which builds packages to follow this pattern
  • Had to tweak prettierignore files to ensure eslint config files are formatted correctly

@times-tools
Copy link
Collaborator

Please find visual snapshots of your changed components here: https://www.bitrise.io/build/9cc132446bbb523e

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling cda5e7e on refactor/jest-eslint-env into ** on master**.

@colincclark colincclark mentioned this pull request Jan 15, 2018
Closed
@times-tools
Copy link
Collaborator

Please find visual snapshots of your changed components here: https://www.bitrise.io/build/5708abd9f6f0e250

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 200d93b on refactor/jest-eslint-env into ** on master**.

@times-tools
Copy link
Collaborator

Please find visual snapshots of your changed components here: https://www.bitrise.io/build/38556d5a6d79f380

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 200d93b on refactor/jest-eslint-env into ** on master**.

craigbilner
craigbilner suggested changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@craigbilner craigbilner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dupe package.json ignore and rebase :-)

@times-tools
Copy link
Collaborator

Please find visual snapshots of your changed components here: https://www.bitrise.io/build/0ec16c3093943f02

craigbilner
craigbilner approved these changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@craigbilner craigbilner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watermark needs to be refactored anyway

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5d0e320 on refactor/jest-eslint-env into ** on master**.

@colincclark colincclark merged commit 0212bb7 into master Jan 15, 2018
@colincclark colincclark deleted the refactor/jest-eslint-env branch January 15, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigbilner craigbilner craigbilner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@colincclark @times-tools @coveralls @craigbilner