Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix messages returning a empty <ul /> #825

Merged
merged 1 commit into from Jul 3, 2015

Conversation

BarryCarlyon
Copy link

As requested in #814 (comment) reopening at devel instead of master

@miguelbalparda
Copy link
Contributor

@BarryCarlyon can you give us a step by step guide to reproduce the issue you were experiencing?

@BarryCarlyon
Copy link
Author

There are no steps.

I was getting a

    for no reason, I traced the issue back to turpentine, as the block hinter was saying it was a turp's block.

    Changed the code in this PR and boom no empty

      anymore

      @csdougliss
      Copy link
      Contributor

      Code seems logical to me 👍

      miguelbalparda added a commit that referenced this pull request Jul 3, 2015
      Fix messages returning a empty <ul />
      @miguelbalparda miguelbalparda merged commit b5ebabf into nexcess:devel Jul 3, 2015
      @miguelbalparda
      Copy link
      Contributor

      Thank you for your contribution @BarryCarlyon!

      @BarryCarlyon BarryCarlyon deleted the patch_messages branch August 10, 2015 10:16
      jeroenvermeulen added a commit to jeroenvermeulen/magento-turpentine that referenced this pull request Aug 26, 2015
      When there were no messages, but there was HTML for the ESI Ajax container, it was thrown. When that happened, there was no ESI container on that page, so messages would never work on that cached page.
      miguelbalparda added a commit that referenced this pull request Aug 27, 2015
      Pull request #825 broke the ESI messages. This commit fixes it.
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      None yet
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      None yet

      4 participants