You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current code for BidGenerator.nextBid incorrectly adds the FIRST_PERSON_ID two times to the value returned by nextBase0PersonId() call (see lines 84 and 100 below):
I only noticed because I'm writing unit-tests (to better understand what each function intends) while porting the data source to rust and my test failed :P.
Or if there is some reason why the FIRST_PERSON_ID is added twice intentionally, perhaps place those together with a comment - but as it is, I'm assuming it's unintended.
The text was updated successfully, but these errors were encountered:
The current code for
BidGenerator.nextBid
incorrectly adds theFIRST_PERSON_ID
two times to the value returned bynextBase0PersonId()
call (see lines 84 and 100 below):nexmark/nexmark-flink/src/main/java/com/github/nexmark/flink/generator/model/BidGenerator.java
Lines 84 to 100 in 54974ef
I only noticed because I'm writing unit-tests (to better understand what each function intends) while porting the data source to rust and my test failed :P.
Or if there is some reason why the
FIRST_PERSON_ID
is added twice intentionally, perhaps place those together with a comment - but as it is, I'm assuming it's unintended.The text was updated successfully, but these errors were encountered: