2주차 - Step2 로또(자동) 피드백 요청드립니다. #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
young891221
approved these changes
Jun 25, 2019
| OutputView.printLottoTickets(lottoTickets); | ||
|
|
||
| LottoTicket luckyNumber = LottoSeller.getLuckyNumber(InputView.askLuckyNumber()); | ||
| Map<LottoRank, List<LottoTicket>> lottoResultMap = LottoSeller.getLottoResult(lottoTickets, luckyNumber); |
There was a problem hiding this comment.
Map<LottoRank, List> lottoResultMap이 아닌
LottoResult같은 객체로 결과를 계산하는 객체가 나오면 좋을것 같네요.
|
|
||
| //Then | ||
| // assertThat(testNumbers.get(0)).isNotEqualTo(1); | ||
| //TODO: 이 테스트는 완전하지 않습니다. 셔플링을 어떻게 테스트하면 좋을까요 |
There was a problem hiding this comment.
랜덤 테스트의 경우는 테스트가 어려운듯 합니다. 굳이 하자면 범위가 맞는지 정도인듯 하네요ㅠㅠ
랜덤이 아닌 수동으로 넣었을 때 올바른 값이 나오는지를 테스트해야될 듯 보입니다ㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요!
로또 결과를 저장하고 출력하는 부분에서 많이 헤매다가 이제서야 요청드립니다.
TDD로 구현하는 과정에서 후반부로 갈수록 메서드간 연관이 깊어졌는데,
이 때 테스트 코드 작성에 소홀했기 때문에 더 헤맸던 것 같습니다..
문제가 많을 것으로 예상됩니다. 많은 지적과 조언 부탁드립니다!!
추가) 2개의 로컬저장소를 번갈아가면서 사용하다가 충돌해소 과정에서 일부 커밋이 병합되어 커밋 단위가 일정하지 않습니다..ㅠ