Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts): extend server type in Email provider from nodemailer #2259

Merged
merged 7 commits into from Jun 27, 2021
Merged

fix(ts): extend server type in Email provider from nodemailer #2259

merged 7 commits into from Jun 27, 2021

Conversation

justinforlenza
Copy link
Contributor

Reasoning 💡

Adds additional typing for SMTP server config for tls & secure from nodemailer

Checklist 🧢

  • Documentation
  • Tests
  • Ready to be merged

Affected issues 🎟

Fixes #807

@vercel
Copy link

vercel bot commented Jun 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/BeFRU7tR7yRnt3GY6qcuZp6HQuig
✅ Preview: https://next-auth-git-fork-justinforlenza-patch-1-nextauthjs.vercel.app

@vercel vercel bot temporarily deployed to Preview June 27, 2021 00:05 Inactive
@github-actions github-actions bot added the TypeScript Issues relating to TypeScript label Jun 27, 2021
@balazsorban44
Copy link
Member

thanks, what about extending the whole option as described in #807 (comment)?

@vercel vercel bot temporarily deployed to Preview June 27, 2021 01:34 Inactive
@justinforlenza
Copy link
Contributor Author

thanks, what about extending the whole option as described in #807 (comment)?

Tbh idk why that just didn't even cross my mind, just made that change to just use the nodemailers built in interface

@balazsorban44
Copy link
Member

balazsorban44 commented Jun 27, 2021

Could you please make sure that you use npm@7 so the lock file doesn't get messed up? 😬 (you can verify by seeing lockFileVersion: 2 near the top)

@vercel vercel bot temporarily deployed to Preview June 27, 2021 16:13 Inactive
@justinforlenza
Copy link
Contributor Author

Could you please make sure that you use npm@7 so the lock file doesn't get messed up

Apoligies, I was trying out gitpod, and didnt realize it didnt have updated NPM

@vercel vercel bot temporarily deployed to Preview June 27, 2021 16:38 Inactive
@balazsorban44 balazsorban44 changed the title fix(ts): added optional secure & TLS types for SMTP Server config fix(ts): extend server type in Email provider from nodemailer Jun 27, 2021
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our TS tests were still failing. I added some suggestions to mitigate them, and I could seemingly also commit them to your fork, so I did. Hope it's OK. 😄

types/providers.d.ts Outdated Show resolved Hide resolved
types/providers.d.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview June 27, 2021 16:44 Inactive
types/providers.d.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview June 27, 2021 16:46 Inactive
types/providers.d.ts Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview June 27, 2021 16:48 Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #2259 (3d984d8) into main (591aa7c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2259   +/-   ##
=====================================
  Coverage   9.97%   9.97%           
=====================================
  Files         82      82           
  Lines       1393    1393           
  Branches     393     393           
=====================================
  Hits         139     139           
  Misses      1028    1028           
  Partials     226     226           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 591aa7c...3d984d8. Read the comment docs.

@balazsorban44 balazsorban44 merged commit ad6c13c into nextauthjs:main Jun 27, 2021
@balazsorban44
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeScript Issues relating to TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Nodemailer option types
3 participants