New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ts): extend server
type in Email provider from nodemailer
#2259
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/BeFRU7tR7yRnt3GY6qcuZp6HQuig |
thanks, what about extending the whole option as described in #807 (comment)? |
Tbh idk why that just didn't even cross my mind, just made that change to just use the nodemailers built in interface |
Could you please make sure that you use npm@7 so the lock file doesn't get messed up? 😬 (you can verify by seeing |
Apoligies, I was trying out gitpod, and didnt realize it didnt have updated NPM |
server
type in Email provider from nodemailer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our TS tests were still failing. I added some suggestions to mitigate them, and I could seemingly also commit them to your fork, so I did. Hope it's OK. 😄
Codecov Report
@@ Coverage Diff @@
## main #2259 +/- ##
=====================================
Coverage 9.97% 9.97%
=====================================
Files 82 82
Lines 1393 1393
Branches 393 393
=====================================
Hits 139 139
Misses 1028 1028
Partials 226 226 Continue to review full report at Codecov.
|
Thank you! |
Reasoning 💡
Adds additional typing for SMTP server config for
tls
&secure
from nodemailerChecklist 🧢
Affected issues 🎟
Fixes #807