From 137bc2d1ad88bbae184637555256902ff5589a1d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?John=20Molakvo=C3=A6?= Date: Tue, 29 Aug 2023 10:31:22 +0200 Subject: [PATCH] feat: provide fileList names as newFileMenu handler argument MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: John Molakvoæ --- __tests__/newFileMenu.spec.ts | 14 +++----------- lib/newFileMenu.ts | 3 ++- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/__tests__/newFileMenu.spec.ts b/__tests__/newFileMenu.spec.ts index 3ac44104..8a7054ad 100644 --- a/__tests__/newFileMenu.spec.ts +++ b/__tests__/newFileMenu.spec.ts @@ -4,14 +4,6 @@ import { NewFileMenu, getNewFileMenu, type Entry } from '../lib/newFileMenu' import logger from '../lib/utils/logger' import { Folder, Permission, View } from '../lib' -const view = new View({ - id: 'files', - name: 'Files', - icon: '', - getContents: async () => ({ folder: {}, contents: [] }), - order: 1, -}) - describe('NewFileMenu init', () => { test('Initializing NewFileMenu', () => { logger.debug = vi.fn() @@ -276,7 +268,7 @@ describe('NewFileMenu getEntries filter', () => { permissions: Permission.ALL, }) - const entries = newFileMenu.getEntries(context, view) + const entries = newFileMenu.getEntries(context) expect(entries).toHaveLength(2) expect(entries[0]).toBe(entry1) expect(entries[1]).toBe(entry2) @@ -312,7 +304,7 @@ describe('NewFileMenu getEntries filter', () => { permissions: Permission.READ, }) - const entries = newFileMenu.getEntries(context, view) + const entries = newFileMenu.getEntries(context) expect(entries).toHaveLength(0) }) @@ -346,7 +338,7 @@ describe('NewFileMenu getEntries filter', () => { root: '/files/admin', }) - const entries = newFileMenu.getEntries(context, view) + const entries = newFileMenu.getEntries(context) expect(entries).toHaveLength(1) expect(entries[0]).toBe(entry1) }) diff --git a/lib/newFileMenu.ts b/lib/newFileMenu.ts index eacafa82..68759e60 100644 --- a/lib/newFileMenu.ts +++ b/lib/newFileMenu.ts @@ -48,8 +48,9 @@ export interface Entry { /** * Function to be run after creation * @param {Folder} context the creation context. Usually the current folder + * @param {string[]} fileList list of file names present in the destination folder */ - handler: (context: Folder) => void + handler: (context: Folder, fileList: string[]) => void } export class NewFileMenu {