From 56eed6acc3c18598a09f106f96921e743106c3ab Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Tue, 18 Jul 2023 12:29:04 +0200
Subject: [PATCH] feat(NcButton): Add `pressed` state for stateful buttons,
 like the `NcAppSidebar` star button

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 src/components/NcAppSidebar/NcAppSidebar.vue |  9 +-
 src/components/NcButton/NcButton.vue         | 90 +++++++++++++++++++-
 2 files changed, 97 insertions(+), 2 deletions(-)

diff --git a/src/components/NcAppSidebar/NcAppSidebar.vue b/src/components/NcAppSidebar/NcAppSidebar.vue
index c2d9cbe9eb..a7860452db 100644
--- a/src/components/NcAppSidebar/NcAppSidebar.vue
+++ b/src/components/NcAppSidebar/NcAppSidebar.vue
@@ -32,6 +32,7 @@ include a standard-header like it's used by the files app.
 ```vue
 <template>
 	<NcAppSidebar
+		:starred="starred"
 		name="cat-picture.jpg"
 		subname="last edited 3 weeks ago">
 		<NcAppSidebarTab name="Search" id="search-tab">
@@ -65,6 +66,11 @@ include a standard-header like it's used by the files app.
 			Cog,
 			ShareVariant,
 		},
+		data() {
+			return {
+				starred: false,
+			}
+		},
 	}
 </script>
 ```
@@ -376,6 +382,7 @@ export default {
 							<slot name="tertiary-actions">
 								<NcButton v-if="canStar"
 									:aria-label="favoriteTranslated"
+									:pressed="isStarred"
 									class="app-sidebar-header__star"
 									type="secondary"
 									@click.prevent="toggleStarred">
@@ -974,7 +981,7 @@ $top-buttons-spacing: 6px;
 				.app-sidebar-header__star {
 					// Override default Button component styles
 					box-shadow: none;
-					&:hover {
+					&:not([aria-pressed="true"]):hover {
 						box-shadow: none;
 						background-color: var(--color-background-hover);
 					}
diff --git a/src/components/NcButton/NcButton.vue b/src/components/NcButton/NcButton.vue
index cd2a5a9c1f..0889a223fb 100644
--- a/src/components/NcButton/NcButton.vue
+++ b/src/components/NcButton/NcButton.vue
@@ -196,6 +196,66 @@ button {
 }
 </style>
 ```
+
+### Pressed state
+It is possible to make the button stateful by adding a pressed state, e.g. if you like to create a favorite button.
+The button will have the required `aria` attribute for accessibility and visual style (`primary` when pressed, and the configured type otherwise).
+
+```vue
+<template>
+	<div>
+		<div style="display: flex; gap: 12px;">
+			<NcButton :pressed="isFavorite" :aria-label="ariaLabel" type="tertiary-no-background" @click="toggleFavorite">
+				<template #icon>
+					<IconStar v-if="isFavorite" :size="20" />
+					<IconStarOutline v-else :size="20" />
+				</template>
+			</NcButton>
+			<NcButton :pressed="isFavorite" :aria-label="ariaLabel" type="tertiary" @click="toggleFavorite">
+				<template #icon>
+					<IconStar v-if="isFavorite" :size="20" />
+					<IconStarOutline v-else :size="20" />
+				</template>
+			</NcButton>
+			<NcButton :pressed="isFavorite" :aria-label="ariaLabel" @click="toggleFavorite">
+				<template #icon>
+					<IconStar v-if="isFavorite" :size="20" />
+					<IconStarOutline v-else :size="20" />
+				</template>
+			</NcButton>
+		</div>
+		<div>
+			It is {{ isFavorite ? 'a' : 'not a' }} favorite.
+		</div>
+	</div>
+</template>
+<script>
+import IconStar from 'vue-material-design-icons/Star.vue'
+import IconStarOutline from 'vue-material-design-icons/StarOutline.vue'
+
+export default {
+	components: {
+		IconStar,
+		IconStarOutline,
+	},
+	data() {
+		return {
+			isFavorite: false,
+		}
+	},
+	computed: {
+		ariaLabel() {
+			return this.isFavorite ? 'Remove as favorite' : 'Add as favorite'
+		},
+	},
+	methods: {
+		toggleFavorite() {
+			this.isFavorite = !this.isFavorite
+		},
+	},
+}
+</script>
+```
 </docs>
 
 <script>
@@ -299,6 +359,33 @@ export default {
 			type: Boolean,
 			default: null,
 		},
+
+		/**
+		 * The pressed state of the button if it has a checked state
+		 * This will add the `aria-pressed` attribute and for the button to have the primary style in checked state.
+		 */
+		pressed: {
+			type: Boolean,
+			default: null,
+		},
+	},
+
+	computed: {
+		/**
+		 * The real type to be used for the button, enforces `primary` for pressed state and, if stateful button, any other type for not pressed state
+		 * Otherwise the type property is used.
+		 */
+		realType() {
+			// Force *primary* when pressed
+			if (this.pressed) {
+				return 'primary'
+			}
+			// If not pressed but button is configured as stateful button then the type must not be primary
+			if (this.pressed === false && this.type === 'primary') {
+				return 'secondary'
+			}
+			return this.type
+		},
 	},
 
 	/**
@@ -332,7 +419,7 @@ export default {
 						'button-vue--icon-only': hasIcon && !hasText,
 						'button-vue--text-only': hasText && !hasIcon,
 						'button-vue--icon-and-text': hasIcon && hasText,
-						[`button-vue--vue-${this.type}`]: this.type,
+						[`button-vue--vue-${this.realType}`]: this.realType,
 						'button-vue--wide': this.wide,
 						active: isActive,
 						'router-link-exact-active': isExactActive,
@@ -340,6 +427,7 @@ export default {
 				],
 				attrs: {
 					'aria-label': this.ariaLabel,
+					'aria-pressed': this.pressed,
 					disabled: this.disabled,
 					type: this.href ? null : this.nativeType,
 					role: this.href ? 'button' : null,