Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User information leaking through debug log prints. #116

Closed
ardevd opened this issue Feb 10, 2018 · 1 comment
Closed

User information leaking through debug log prints. #116

ardevd opened this issue Feb 10, 2018 · 1 comment
Milestone

Comments

@ardevd
Copy link

ardevd commented Feb 10, 2018

adb logcat reveals several debug log entries marked with "GetRemoteUserInfoOperation". Here is one example.

02-09 23:12:33.410 28516 3060 D GetRemoteUserInfoOperation: Successful response: {"ocs":{"meta":{"status":"ok","statuscode":100,"message":"OK","totalitems":"","itemsperpage":""},"data":{"enabled":"true","id":"xxx","quota":{"free":110406975803,"used":50654297797,"total":161061273600,"relative":31.45,"quota":161061273600},"email":"xxx@xxx.xx","phone":"","address":"","website":"https:\/\/redacted.com","twitter":"@redacted","groups":["admin"],"language":"en","display-name":"Redacted"}}}

It makes sense to print these as a debugging measure, but it doesnt belong in a production ready deployment. My recommendation would either be to use a wrapper class to filter the log prints away from RELEASE builds or use Proguard to filter out the debug code completely.

@ardevd
Copy link
Author

ardevd commented Feb 11, 2018

I believe #118 is a better fix.

@mario mario closed this as completed in eb85387 Feb 12, 2018
mario added a commit that referenced this issue Feb 12, 2018
Fixes #116: Remove leaking of user sensitive information
@AndyScherzinger AndyScherzinger added this to the NC lib 1.0.38 milestone Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants